Skip to content

chore: bump model registry dependency to 0.3.3 #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: incubating
Choose a base branch
from
Open

chore: bump model registry dependency to 0.3.3 #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59a48fe
chore: bump model registry dependency to 0.3.3
Al-Pragliola Nov 11, 2025
72d33cb
chore: remove useless replace
Al-Pragliola Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 36 additions & 32 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,46 +9,48 @@ require (
github.com/hashicorp/errwrap v1.1.0
github.com/hashicorp/go-multierror v1.1.1
github.com/kedacore/keda/v2 v2.16.1
github.com/kserve/kserve v0.15.0
github.com/kserve/kserve v0.15.2
github.com/kuadrant/authorino-operator v0.11.1
github.com/kuadrant/kuadrant-operator v1.2.0
github.com/kubeflow/model-registry v0.2.19
github.com/onsi/ginkgo/v2 v2.23.4
github.com/onsi/gomega v1.37.0
github.com/kubeflow/model-registry v0.3.3
github.com/kubeflow/model-registry/pkg/openapi v0.3.3
github.com/onsi/ginkgo/v2 v2.27.1
github.com/onsi/gomega v1.38.2
github.com/openshift/api v0.0.0-20250102185430-d6d8306a24ec
github.com/openshift/client-go v0.0.0-20250102190827-c8a353937472
github.com/pkg/errors v0.9.1
github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.76.2
github.com/stretchr/testify v1.10.0
github.com/stretchr/testify v1.11.1
go.uber.org/zap v1.27.0
google.golang.org/protobuf v1.36.6
google.golang.org/protobuf v1.36.10
istio.io/api v1.26.4
istio.io/client-go v1.26.4
k8s.io/api v0.33.1
k8s.io/api v0.33.5
k8s.io/apiextensions-apiserver v0.33.1
k8s.io/apimachinery v0.33.1
k8s.io/apimachinery v0.33.5
k8s.io/apiserver v0.33.1
k8s.io/client-go v0.33.1
k8s.io/client-go v0.33.5
k8s.io/utils v0.0.0-20250321185631-1f6e0b77f77e
knative.dev/pkg v0.0.0-20250117084104-c43477f0052b
sigs.k8s.io/controller-runtime v0.20.4
sigs.k8s.io/controller-runtime v0.21.0
Copy link

@coderabbitai coderabbitai bot Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify controller-runtime v0.21.0 compatibility with Kubernetes v0.33.5.

The PR bumps controller-runtime to v0.21.0 in line with Kubernetes API/apimachinery/client-go updates to v0.33.5. Additionally, line 174 contains a replace directive for KEDA compatibility that pins controller-runtime to v0.19.1. Verify that:

  1. controller-runtime v0.21.0 is compatible with Kubernetes v0.33.5
  2. The KEDA workaround at line 174 is still valid or needs updating for the new controller-runtime version
  3. No breaking changes exist in controller-runtime v0.21.0 that affect this codebase

🌐 Web query:

Is controller-runtime v0.21.0 compatible with Kubernetes v0.33.5?

💡 Result:

Yes. controller-runtime v0.21.0 targets the k8s.io/* 0.33 line (bumped to v0.33.0), so using Kubernetes/client-go/apimachinery v0.33.5 is compatible (patch releases within the same minor are supported). [1][2]

Sources:
[1] controller-runtime compatibility table (README).
[2] controller-runtime v0.21.0 release notes.


---

🏁 Script executed:

```shell
#!/bin/bash
# Check line 174 in go.mod and surrounding context
sed -n '170,180p' go.mod

Length of output: 384

🏁 Script executed:

#!/bin/bash
# Search for KEDA references in the codebase
rg -i "keda" --type yaml --type go -C 2

Length of output: 79967

🏁 Script executed:

#!/bin/bash
# Search web for KEDA and controller-runtime v0.21.0 compatibility
echo "Will search for KEDA controller-runtime compatibility if needed"

Length of output: 63

🌐 Web query:

KEDA controller-runtime v0.21.0 v0.20.0 compatibility support

💡 Result:

Short answer: controller-runtime v0.21 is a breaking-minor bump (k8s.io/* → v0.33, Go 1.24, several API/behavior changes) so it is not drop‑in compatible with older controller-runtime minors; KEDA has reported incompatibility problems with controller-runtime ≥ v0.20 (webhook.Validator/deprecated webhook API issues). See the controller-runtime release notes/versioning and the KEDA issue for details. [1][2][3]

Sources

  • controller-runtime v0.21.0 release notes (breaking changes: k8s.io/* v0.33, Go 1.24, deprecations). [1]
  • controller-runtime compatibility/versioning table (CR v0.21 → k8s.io v0.33; CR v0.20 → k8s.io v0.32). [2]
  • KEDA GitHub issue reporting incompatibility with controller-runtime ≥ v0.20 (webhook.Validator deprecation). [3]

Conflicting controller-runtime versions in go.mod: line 34 declares v0.21.0 but line 174 replace directive forces v0.19.1.

The replace directive at line 174 overrides the v0.21.0 specified at line 34, meaning the actual controller-runtime version will be v0.19.1, not v0.21.0. While KEDA has reported incompatibility with controller-runtime ≥ v0.20 (validating the workaround), this creates a contradiction in the PR:

  • If v0.21.0 cannot be used due to KEDA incompatibility, the declaration at line 34 should remain v0.19.1
  • If v0.21.0 is intended, the replace directive must be removed or updated, and KEDA compatibility must be resolved

Clarify the intent and reconcile these conflicting directives.

🤖 Prompt for AI Agents 
In go.mod around lines 34 and 174, there is a conflict: line 34 declares
controller-runtime v0.21.0 while a replace directive at line 174 forces v0.19.1;
reconcile by choosing one source of truth — either change the module declaration
at line 34 to v0.19.1 to match the replace (if KEDA incompatibility prevents
using v0.20+), or remove/update the replace directive to allow v0.21.0 and then
resolve the KEDA compatibility issues; after making the change, run go mod tidy
(and rebuild/tests) to update go.sum and verify the project compiles with the
selected controller-runtime version.

sigs.k8s.io/gateway-api v1.2.1
sigs.k8s.io/gateway-api-inference-extension v0.3.0
sigs.k8s.io/yaml v1.4.0
)

require (
cel.dev/expr v0.20.0 // indirect
cel.dev/expr v0.24.0 // indirect
cloud.google.com/go v0.116.0 // indirect
cloud.google.com/go/auth v0.15.0 // indirect
cloud.google.com/go/auth/oauth2adapt v0.2.7 // indirect
cloud.google.com/go/compute/metadata v0.6.0 // indirect
cloud.google.com/go/compute/metadata v0.7.0 // indirect
cloud.google.com/go/iam v1.2.2 // indirect
cloud.google.com/go/monitoring v1.22.0 // indirect
cloud.google.com/go/storage v1.50.0 // indirect
github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp v1.26.0 // indirect
github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp v1.27.0 // indirect
github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric v0.48.1 // indirect
github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping v0.48.1 // indirect
github.com/Masterminds/semver/v3 v3.4.0 // indirect
github.com/antlr4-go/antlr/v4 v4.13.0 // indirect
github.com/aws/aws-sdk-go v1.55.6 // indirect
github.com/beorn7/perks v1.0.1 // indirect
Expand All @@ -57,7 +59,7 @@ require (
github.com/cenkalti/backoff/v4 v4.3.0 // indirect
github.com/cert-manager/cert-manager v1.16.3 // indirect
github.com/cespare/xxhash/v2 v2.3.0 // indirect
github.com/cncf/xds/go v0.0.0-20250121191232-2f005788dc42 // indirect
github.com/cncf/xds/go v0.0.0-20250501225837-2ac532fd4443 // indirect
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
github.com/emicklei/dot v1.6.2 // indirect
github.com/emicklei/go-restful/v3 v3.12.2 // indirect
Expand Down Expand Up @@ -112,44 +114,46 @@ require (
github.com/prometheus/procfs v0.16.1 // indirect
github.com/samber/lo v1.47.0 // indirect
github.com/sirupsen/logrus v1.9.3 // indirect
github.com/spf13/cobra v1.9.1 // indirect
github.com/spf13/pflag v1.0.6 // indirect
github.com/spf13/cobra v1.10.1 // indirect
github.com/spf13/pflag v1.0.10 // indirect
github.com/spiffe/go-spiffe/v2 v2.5.0 // indirect
github.com/stoewer/go-strcase v1.3.0 // indirect
github.com/telepresenceio/watchable v0.0.0-20220726211108-9bb86f92afa7 // indirect
github.com/x448/float16 v0.8.4 // indirect
github.com/zeebo/errs v1.4.0 // indirect
go.opencensus.io v0.24.0 // indirect
go.opentelemetry.io/auto/sdk v1.1.0 // indirect
go.opentelemetry.io/contrib/detectors/gcp v1.34.0 // indirect
go.opentelemetry.io/contrib/detectors/gcp v1.36.0 // indirect
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.59.0 // indirect
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.60.0 // indirect
go.opentelemetry.io/otel v1.35.0 // indirect
go.opentelemetry.io/otel v1.36.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.33.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.33.0 // indirect
go.opentelemetry.io/otel/metric v1.35.0 // indirect
go.opentelemetry.io/otel/sdk v1.35.0 // indirect
go.opentelemetry.io/otel/sdk/metric v1.35.0 // indirect
go.opentelemetry.io/otel/trace v1.35.0 // indirect
go.opentelemetry.io/otel/metric v1.36.0 // indirect
go.opentelemetry.io/otel/sdk v1.36.0 // indirect
go.opentelemetry.io/otel/sdk/metric v1.36.0 // indirect
go.opentelemetry.io/otel/trace v1.36.0 // indirect
go.opentelemetry.io/proto/otlp v1.4.0 // indirect
go.uber.org/automaxprocs v1.6.0 // indirect
go.uber.org/multierr v1.11.0 // indirect
golang.org/x/crypto v0.39.0 // indirect
go.yaml.in/yaml/v3 v3.0.4 // indirect
golang.org/x/crypto v0.41.0 // indirect
golang.org/x/exp v0.0.0-20250606033433-dcc06ee1d476 // indirect
golang.org/x/net v0.41.0 // indirect
golang.org/x/mod v0.27.0 // indirect
golang.org/x/net v0.43.0 // indirect
golang.org/x/oauth2 v0.30.0 // indirect
golang.org/x/sync v0.15.0 // indirect
golang.org/x/sys v0.33.0 // indirect
golang.org/x/term v0.32.0 // indirect
golang.org/x/text v0.26.0 // indirect
golang.org/x/sync v0.16.0 // indirect
golang.org/x/sys v0.36.0 // indirect
golang.org/x/term v0.34.0 // indirect
golang.org/x/text v0.28.0 // indirect
golang.org/x/time v0.12.0 // indirect
golang.org/x/tools v0.34.0 // indirect
golang.org/x/tools v0.36.0 // indirect
gomodules.xyz/jsonpatch/v2 v2.5.0 // indirect
google.golang.org/api v0.226.0 // indirect
google.golang.org/genproto v0.0.0-20241118233622-e639e219e697 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20250324211829-b45e905df463 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20250324211829-b45e905df463 // indirect
google.golang.org/grpc v1.72.1 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20250528174236-200df99c418a // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20250528174236-200df99c418a // indirect
google.golang.org/grpc v1.74.2 // indirect
gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect
gopkg.in/go-playground/validator.v9 v9.31.0 // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
Expand Down
Loading