Skip to content

NO-JIRA: chore(Makefile): remove BUILD_DEPENDENT_IMAGES option #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

NO-JIRA: chore(Makefile): remove BUILD_DEPENDENT_IMAGES option #934

merged 1 commit into from
Mar 4, 2025

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Mar 4, 2025 •
edited by openshift-ci bot
Loading

Description

The recent change RHOAIENG-19048 that removed build chains made the option obsolete

This modifies the Makefile customization feature as implemented in RHOAIENG-9822

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jiridanek
NO-JIRA: chore(Makefile): remove BUILD_DEPENDENT_IMAGES option
f6d1376 
The recent change RHOAIENG-19048 that removed build chains made the option obsolete

* opendatahub-io#924

This modifies the Makefile customization feature as implemented in RHOAIENG-9822

* opendatahub-io#657
@jiridanek jiridanek requested a review from andyatmiami March 4, 2025 10:11
@openshift-ci openshift-ci bot requested review from atheo89 and harshad16 March 4, 2025 10:11
@jiridanek jiridanek changed the title NO-JIRA: chore(Makefile): remove BUILD_DEPENDENT_IMAGES option NO-JIRA: chore(Makefile): remove BUILD_DEPENDENT_IMAGES option Mar 4, 2025
@openshift-ci openshift-ci bot added size/s and removed size/s labels Mar 4, 2025
@jstourac
Copy link
Member

jstourac commented Mar 4, 2025

/lgtm

1 similar comment
@jstourac
Copy link
Member

jstourac commented Mar 4, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 4, 2025
@jiridanek
Copy link
Member Author

/approve

1 similar comment
@jiridanek
Copy link
Member Author

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 4, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit f66abc4 into opendatahub-io:main Mar 4, 2025
7 checks passed
@jiridanek jiridanek deleted the jd_remove_obsolete_mkfile_flag branch March 18, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyatmiami andyatmiami Awaiting requested review from andyatmiami

@atheo89 atheo89 Awaiting requested review from atheo89

@harshad16 harshad16 Awaiting requested review from harshad16

Assignees

@jstourac jstourac

Labels
approved lgtm size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiridanek @jstourac