Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-17006: chore(pyproject.toml): migrate test dependencies from poetry to uv #917

Merged
merged 1 commit into from
Apr 6, 2025

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Feb 23, 2025

https://issues.redhat.com/browse/RHOAIENG-17006

Description

Good first step to unify everything on uv if we are later going to migrate the notebook images from Pipenv to uv.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from dibryant and jstourac February 23, 2025 13:13
@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels Feb 23, 2025
@jstourac
Copy link
Member

LGTM in general, but we should either link this with some tracking issue or provide some explanation and motivation why we are doing this change so we know in the future.

@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels Feb 25, 2025
@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels Feb 26, 2025
@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels Feb 26, 2025
@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels Mar 17, 2025
@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels Mar 17, 2025
@jiridanek jiridanek changed the title NO-ISSUE: chore(pyproject.toml): migrate from poetry to uv NO-ISSUE: chore(pyproject.toml): migrate tests/ from poetry to uv Mar 17, 2025
@openshift-ci openshift-ci bot removed the size/xxl label Mar 17, 2025
@jiridanek
Copy link
Member Author

Addressed the review comments, thanks

/approve

Copy link
Contributor

openshift-ci bot commented Apr 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 6, 2025
@jiridanek jiridanek merged commit 0e975a2 into opendatahub-io:main Apr 6, 2025
9 of 10 checks passed
@jiridanek jiridanek deleted the jd_uv branch April 6, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants