-
Notifications
You must be signed in to change notification settings - Fork 83
feat(containers): Remove reliance on chained builds #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(containers): Remove reliance on chained builds #908
Conversation
**warning: this is only a partial change with 2024a changes included to solicit initial feedback on approach** Commit contains following changes: - Refactors all `Dockerfile`s to to be "self-contained" - not rely on any "build chains" for internal images - please note in the final form of this PR - many intermediate stages will be combined... this current form makes it easier to understand how the `Dockerfile`s present in the "build chain" are being combined - long term - we'd expect the following stages: `base`, `base-<accelerator>` (if applicable), `<final>` - `Dockerfile` file now has a file extension/suffix that indicates CPU or accelerator - `LABEL` directives now should be consistent/accurate - this probably needs a little more attention - `base/` directory removed as its no longer relevant/required - Makefile updated to handle support better across releases - _read: MOWR variables_ - `wheel` / `setuptools` explicitly added to `runtime-` images `Pipfile` - `pytorch` `Makefile` targets now contain `cuda-` prefix - `ENV` directive in `Dockerfile` now properly uses `=` (vs. whitespace) - change in `buildinputs` to pull file paths from the terminal layer - this change particularly needs refined - but its "crude yet effective" in its current form Related-to: https://issues.redhat.com/browse/RHOAIENG-19048
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this is a partial/incomplete set of changes... will not ever merge these changes... going to use as a staging ground as we spin up a new branch off main based on recent change in direction.
GHA is looking happy r.n. |
closing this PR as I will be (soon!) opened another to replace it... conceptually... changes in the new PR are the same - just adapted to note require the 2024a + 2024b subdirectories now. |
Description
warning: this is only a partial change with 2024a changes included to solicit initial feedback on approach
Commit contains following changes:
Dockerfile
s to to be "self-contained" - not rely on any "build chains" for internal imagesDockerfile
s present in the "build chain" are being combined - long term - we'd expect the following stages:base
,base-<accelerator>
(if applicable),<final>
Dockerfile
file now has a file extension/suffix that indicates CPU or acceleratorLABEL
directives now should be consistent/accuratebase/
directory removed as its no longer relevant/requiredrocm/
related directories removed asROCm
was not actually supported in2024a
wheel
/setuptools
explicitly added toruntime-
imagesPipfile
pytorch
Makefile
targets now containcuda-
prefixENV
directive inDockerfile
now properly uses=
(vs. whitespace)buildinputs
to pull file paths from the terminal layerRelated-to: https://issues.redhat.com/browse/RHOAIENG-19048
How Has This Been Tested?
2024a
branch as seen here:Merge criteria: