chore(docs): update install instructions #178
Conversation
|
@pboyd congrats on your first PR for the project. The changes look good to me. If you want to finalize them after the ODH operator's new version with DEFAULT-CERT fix, we can merge this. |
pboyd
force-pushed
the
install-doc-updates
branch
2 times, most recently
from
1b7c95f to
cd17641
Compare
|
I pushed an update to switch back to the "Technical Preview" version of Authorino (which, as @dhirajsb found out, works fine on OpenShift 4.16). There is still an outstanding issue in the install docs with ODH 2.22.0, which can be avoided with @Al-Pragliola's workaround. I didn't include that in the docs as I hope it will be resolved soon. |
docs/install.md
Outdated
| @@ -464,24 +469,24 @@ oc patch odhdashboardconfig.opendatahub.io odh-dashboard-config -n opendatahub - | |||
| Model Registry uses service mesh and opens a Gateway for external clients to reach. Execute following to find the URL where Model Registry is available. | |||
|
|
|||
| ``` | |||
| URL=`echo "https://$(oc get routes -n istio-system -l app.kubernetes.io/name=modelregistry-public -o json | jq '.items[].status.ingress[].host | select(contains("-rest"))')" | tr -d '"'` | |||
| echo "https://$(oc get routes -n istio-system -l app.kubernetes.io/name=modelregistry-public -o json | jq '.items[].status.ingress[].host | select(contains("-rest"))')" | tr -d '"' | |||
There was a problem hiding this comment.
don't we need the URL variable in line 480?
There was a problem hiding this comment.
I overlooked that. It's back to how it was originally, thanks for the catch.
- Fix serverless operator install instructions - Bump versions for authorino, servicemeshoperator, opendatahub-operator
pboyd
force-pushed
the
install-doc-updates
branch
from
cd17641 to
5d515b8
Compare
|
Hold off on merging this as @rareddy has advised to rollback to Authorino v1beta2 as there are customer issues in updating to stable channel. I'm creating a PR to do the rollback. |
Description
How Has This Been Tested?
Ran through instructions.
Merge criteria: