Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): improved tests coverage unit/integration #177

Conversation

Al-Pragliola
Copy link
Contributor

Description

Improved tests coverage from:

image

to:

image

How Has This Been Tested?

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@Al-Pragliola Al-Pragliola force-pushed the al-pragliola-improve-integration-tests branch from f1b089e to 430b918 Compare December 23, 2024 22:35
@Al-Pragliola Al-Pragliola requested a review from dhirajsb January 2, 2025 10:36
dhirajsb
dhirajsb previously approved these changes Feb 4, 2025
Copy link
Contributor

@dhirajsb dhirajsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm please rebase and squash and merge 👍

@Al-Pragliola Al-Pragliola force-pushed the al-pragliola-improve-integration-tests branch from 430b918 to 51567e0 Compare February 5, 2025 14:58
@Al-Pragliola Al-Pragliola merged commit 21c0883 into opendatahub-io:main Feb 5, 2025
2 checks passed
@Al-Pragliola Al-Pragliola deleted the al-pragliola-improve-integration-tests branch February 5, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants