Skip to content

Conversation

@SBCV
Copy link
Contributor

@SBCV SBCV commented Mar 20, 2019

While using videostab.cpp to perform video stabilization, I experienced several times sub-optimal results. Using the visualization of this PR showed that in my sequences too many feature points are being detected on independently moving objects (in my case vehicles).

I tried to stay as close as possible to the original implementation and determined the output (hopefully) with a minimal amount of changes.

This pull request changes

This PR adds an option to videostab/samples/videostab.cpp, which allows to define an additional video output paths for an overlay of the original video and feature locations used for image stabilization.

@SBCV
Copy link
Contributor Author

SBCV commented Mar 22, 2019

Just discovered that no output is generated, when transformations are written to disc ...
I'll check what is going wrong and update the PR

@SBCV
Copy link
Contributor Author

SBCV commented Mar 25, 2019

Fixed bug, improved performance & reduced number of new lines using a callback

@asmorkalov
Copy link
Contributor

Looks good for me 👍 . @alalek What do you say?

@alalek
Copy link
Member

alalek commented Oct 12, 2019

  1. Lifetime of callback-related objects. std::function with lambdas must be used very accurate.
  2. OpenCV bindings (Python, Java). We need robust solution to support them too.

@asmorkalov asmorkalov self-requested a review October 14, 2019 08:56
@SBCV
Copy link
Contributor Author

SBCV commented Oct 14, 2019

Hi, thank you for having a look.
Unfortunately, your last message was a bit unclear to me. Are there some callback-related lines that must be changed?
I'm not familiar with Python/Java bindings. What kind of lines could cause troubles?
Side note: At the time when I wrote this PR, the video stabilization tool of OpenCV had no python bindings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants