contrib/completions: sync bash completion with current CLI#5299
Open
immanuwell wants to merge 1 commit into
Open
contrib/completions: sync bash completion with current CLI#5299immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
kolyshkin
reviewed
May 26, 2026
kolyshkin
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall, although runc features is not really targeted to be used from CLI (it's for upper-level runtime to query what's available and what's not).
Contributor
|
@immanuwell your test cases are failing. I am also unsure if it makes sense to perform such kind of tests. |
e5b08af to
99333c1
Compare
Author
|
@kolyshkin I addressed all your suggestions, PTAL |
Sync bash completion with the current CLI surface, including missing and corrected flags, plus a regression test for the observed completion drift. Signed-off-by: immanuwell <pchpr.00@list.ru>
99333c1 to
7f2523e
Compare
Contributor
|
Basically, same feedback:
To me, a good test would be some check that if a new option is ever added, it's also mentioned in bash completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bash completion drifted from the current CLI a bit.
Repro on current main:
runc ferunc run --krunc run --drunc delete --frunc exec --trunc list --formatfeaturesis missing--keepis missing--detatchis suggested--format,is suggested fordelete--tty,is suggested forexectextis suggested forlist --format, but help saystable|jsonThis syncs the completion script with the current
--helpoutput, adds the missing entries, and adds a small regression test.Pretty small fix, but nice QoL. easy to hit when you tab around.