Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extremePools.m #2387

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Conversation

farid-zare
Copy link
Collaborator

Fixing two issues with the extremePools:

  1. columns were being removed except of rows
  2. N was being inputed to LRS in the transposed format wrongly
  • Explain why we use N = S^T,
  • Describe the zero RHS and equality constraints,
  • Note the check ensuring P*N' == 0 for the left null space.

Please include a short description of enhancement here

I hereby confirm that I have:

  • Tested my code on my own machine
  • Followed the guidelines in the Contributing Guide
  • Selected develop as a target branch (top left drop-down menu)

(Note: You may replace [ ] with [X] to check the box)

- Explain why we use N = S^T,
- Describe the zero RHS and equality constraints,
- Note the check ensuring P*N' == 0 for the left null space.
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 0.01%. Comparing base (9841d48) to head (f883bab).
Report is 1853 commits behind head on develop.

Files with missing lines Patch % Lines
...c/analysis/topology/extremeRays/lrs/extremePools.m 0.00% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (9841d48) and HEAD (f883bab). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9841d48) HEAD (f883bab)
1 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2387       +/-   ##
============================================
- Coverage    39.01%    0.01%   -39.01%     
============================================
  Files          961     2170     +1209     
  Lines        69151   160507    +91356     
============================================
- Hits         26980       18    -26962     
- Misses       42171   160489   +118318     
Flag Coverage Δ
matlab 0.01% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/analysis/topology/extremeRays/lrs/extremePools.m 0.00% <0.00%> (-74.36%) ⬇️

... and 1826 files with indirect coverage changes

@farid-zare farid-zare merged commit 2f5c6ab into opencobra:develop Feb 1, 2025
1 of 4 checks passed
@farid-zare farid-zare requested a review from rmtfleming February 4, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant