Repository navigation
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 281 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
butonic
reviewed
Oct 30, 2026
| | `outcome`, `outcome.reason` | `success`, `failure` or `denied`, with a machine readable reason on failures | | ||
| | `severity` | `info`, `notice`, `warning` or `alert`; failures and denials are at least `warning` | | ||
| | `tenant.id` | empty on single-tenant installations | | ||
| | `actor.type`, `actor.id`, `actor.name`, `actor.impersonated_by` | type is `user`, `service`, `public_link`, `guest`, `anonymous`, `system` or `cli` | |
Member
There was a problem hiding this comment.
Müsste actor.impersonated_by nicht auch actor.impersonated_by_id und actor.impersonated_by_name sein? außerdem ist die id ja eher nur bei uns zu finden. vllt ist die email da etwas schöner? kann ja optional sein?
micbar
added a commit
to maki5/opencloud
that referenced
this pull request
Oct 30, 2026
chi's ClientIPFrom* header middlewares trust the header from anyone who can
reach us. Pick the middleware per request instead: headers are only read
when the peer is a trusted proxy, everyone else gets their network address.
- PROXY_TRUSTED_PROXIES, defaults to loopback and private ranges
- PROXY_CLIENT_IP_HEADER, defaults to X-Forwarded-For, e.g. CF-Connecting-IP
- drop the strategy setting and xff_trusted_hops
- pass the client address to the services in X-Forwarded-For instead of
X-Client-Ip, reva reads it e.g. for OCM
- same check in collaboration, traefik routes to it directly
- OC_TRUSTED_PROXIES and OC_CLIENT_IP_HEADER set both services
- the other services only drop RealIP, none of them reads the address
Taken from opencloud-eu#3864 and opencloud-eu#3464 (comment)
chi's ClientIPFrom* header middlewares trust the header from anyone who can
reach us. Pick the middleware per request instead: headers are only read
when the peer is a trusted proxy, everyone else gets their network address.
- PROXY_TRUSTED_PROXIES, defaults to loopback and private ranges
- PROXY_CLIENT_IP_HEADER, defaults to X-Forwarded-For, e.g. CF-Connecting-IP
- drop the strategy setting and xff_trusted_hops
- pass the client address to the services in X-Forwarded-For instead of
X-Client-Ip, reva reads it e.g. for OCM
- same check in collaboration, traefik routes to it directly
- OC_TRUSTED_PROXIES and OC_CLIENT_IP_HEADER set both services
- the other services only drop RealIP, none of them reads the address
Taken from #3864 and #3464 (comment)
# Conflicts:
# services/proxy/README.md
Member
Author
micbar
added a commit
that referenced
this pull request
Oct 30, 2026
chi's ClientIPFrom* header middlewares trust the header from anyone who can
reach us. Pick the middleware per request instead: headers are only read
when the peer is a trusted proxy, everyone else gets their network address.
- PROXY_TRUSTED_PROXIES, defaults to loopback and private ranges
- PROXY_CLIENT_IP_HEADER, defaults to X-Forwarded-For, e.g. CF-Connecting-IP
- drop the strategy setting and xff_trusted_hops
- pass the client address to the services in X-Forwarded-For instead of
X-Client-Ip, reva reads it e.g. for OCM
- same check in collaboration, traefik routes to it directly
- OC_TRUSTED_PROXIES and OC_CLIENT_IP_HEADER set both services
- the other services only drop RealIP, none of them reads the address
Taken from #3864 and #3464 (comment)
# Conflicts:
# services/proxy/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First part of the audit log from ADR 0006. The services emit audit events into the JetStream stream
audit, the audit service writes every event as one line of JSON to stdout and, if configured, to an OpenTelemetry Collector.AUDIT_LEGACY_ENABLEDX-Audit-ContextOC_AUDIT_ENABLED=trueandOC_ADD_RUN_SERVICES=auditNeeds #3464, the first four commits are from there.
Needs opencloud-eu/reva#956, the reva bump and the vendoring are still missing.
Related Issue
Motivation and Context
The old audit log is built from the domain events. It only sees successful actions, has no client address and its records have no stable format for a SIEM.
How Has This Been Tested?
opencloud serverwithOC_AUDIT_ENABLED=true, the audit service in its own processpkg/auditScreenshots (if appropriate):
Types of changes
Checklist: