Fix endless loop in wizard od failed auth

[TheOneRing]

No description provided.

[Copilot]

🟡 Changes recommended

There are confirmed control-flow issues that can emit success after failure (and still run WebFinger lookup on insecure-url errors), plus null-safety gaps for the new “OAuth pointer may be null” behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR adjusts the OAuth credentials step in the new setup wizard to avoid re-triggering authentication indefinitely after a failed OAuth attempt, by introducing an explicit “failed/error” state and a retry path to restart authentication from the UI.

Changes:

• Add a retry signal (evaluationRetry) and wire it through the controller to re-evaluate the current wizard state without treating it as a failure.
• Update the OAuth credentials wizard state to support a “failed” mode (no OAuth object) and allow restarting auth from the page/UI.
• Make QmlOAuthCredentials tolerate OAuth* == nullptr for error-state rendering.

File summaries

File	Description
src/gui/newwizard/states/oauthcredentialssetupwizardstate.h	Extend credentials state constructor to accept a “failed” flag.
src/gui/newwizard/states/oauthcredentialssetupwizardstate.cpp	Add failed-mode behavior, restart wiring, and updated OAuth result handling.
src/gui/newwizard/states/abstractsetupwizardstate.h	Introduce evaluationRetry signal for retrying a state evaluation.
src/gui/newwizard/setupwizardcontroller.cpp	Pass failure reason into credentials state and add retry handling in controller.
src/gui/newwizard/setupwizardcontroller_p.h	Extend ChangeReason with EvaluationRetry.
src/gui/newwizard/pages/oauthcredentialssetupwizardpage.h	Add requestAuthRestart signal from the credentials page.
src/gui/newwizard/pages/oauthcredentialssetupwizardpage.cpp	Forward QML restart requests to the page signal.
src/gui/creds/qmlcredentials.h	Document that OAuth pointer may be null in error state; add restart signal.
src/gui/creds/qmlcredentials.cpp	Guard OAuth signal hookups when OAuth is null (error state).

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 4
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.