Display logout button if reauthentication failed - #1089
Open
TheOneRing wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new failed-authentication layout likely breaks Shift+Tab keyboard navigation due to Keys.onBacktabPressed being attached to the Loader instead of the first focusable control.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the OAuth credentials QML UI so that users can access the “Stay logged out” action even when reauthentication fails, aligning the failed-authentication screen with the refresh/reauth flow behavior.
Changes:
- Add a logout-button
Loaderto the “login failed” view inOAuthCredentials.qml. - Add an explanatory comment for the logout button visibility in
Credentials.qml.
File summaries
| File | Description |
|---|---|
| src/gui/qml/credentials/OAuthCredentials.qml | Adds a second view-state placement for the logout button so it can appear when authentication is invalid/failed. |
| src/gui/qml/credentials/Credentials.qml | Documents that the logout button is hidden in the wizard context. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
TheOneRing
force-pushed
the
work/logout
branch
3 times, most recently
from
September 8, 2026 12:54
07c5c4e to
6a33d90
Compare
TheOneRing
force-pushed
the
work/logout
branch
from
September 8, 2026 13:02
6a33d90 to
cc77648
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.