Parse logging - #1085
Open
dragotin wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
It includes a few user-visible spelling issues and a timestamp error-handling behavior that can silently produce misleading flow timings.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds admin-facing logging utilities to parse OpenCloud client log output and extract HTTP request/response data, emitting either an HTML report or a mitmproxy flow file for debugging.
Changes:
- Added
admin/logging/parse_http_logs.pyto parsesync.httploggerlog lines and generate.mitmor HTML output. - Added brief documentation in
admin/logging/README.mddescribing the logging utilities folder.
File summaries
| File | Description |
|---|---|
admin/logging/README.md |
Introduces a short description of the new admin logging utilities directory. |
admin/logging/parse_http_logs.py |
Implements parsing of client HTTP logs and output generation to HTML or mitmproxy flow format. |
Review details
Suppressed comments (1)
admin/logging/parse_http_logs.py:67
- If parse_timestamp() returns None for a malformed timestamp, parse_log() should skip the line rather than proceeding with a None timestamp.
timestamp = parse_timestamp(match.group('ts'))
try:
- Files reviewed: 2/2 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+3
to
+4
| This folder contains helpers for admins to work wtih logging the | ||
| OpenCloud client creates if enabled in the UI of the client. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a script that parses the log output of the client and extracts the http logs, output either in html or mitm proxy flow file