Skip to content

Remove ability to use non-sqlite db in tests #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove ability to use non-sqlite db in tests #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef434df
Remove ability to use non-sqlite db in tests
devsjc May 31, 2023
06806cc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 31, 2023
5145b96
Woops
devsjc May 31, 2023
0bb9881
Missed another bit
devsjc May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nowcasting_datamodel/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def make_partitions(self):
):
partition.__table__.create(bind=self.engine)

def drop_all(self):
def __drop_all(self):
"""Drop all partitions and tables"""
# drop partitions
for partition in self.partitions:
Expand Down
4 changes: 2 additions & 2 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def forecasts_all(db_session) -> List[ForecastSQL]:

@pytest.fixture
def db_connection():
url = os.getenv("DB_URL", "sqlite:///test.db")
url = "sqlite:///test.db"

connection = DatabaseConnection(url=url, echo=False)
connection.create_all()
Expand Down Expand Up @@ -80,7 +80,7 @@ def db_session(db_connection):

@pytest.fixture
def db_connection_pv():
url = os.getenv("DB_URL_PV", "sqlite:///test_pv.db")
url = "sqlite:///test_pv.db"

connection = DatabaseConnection(url=url, base=Base_PV)
Base_PV.metadata.create_all(connection.engine)
Expand Down