-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: added template for cloudcasting ui #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, but otherwise a good start! 👍
export const metadata: Metadata = { | ||
title: 'Cloudcasting UI', | ||
description: | ||
'Next Generation Model to predict the movement of clouds 3Hrs in advance ny Open Climate Fix', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in "ny"
@@ -1,19 +0,0 @@ | |||
name: Non-Default Branch Push CI (Python) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll probably want one of these files to run CI on push/PR for Jest tests etc.
@@ -1,152 +1,36 @@ | |||
# OCF Template | |||
This is a [Next.js](https://nextjs.org) project bootstrapped with [`create-next-app`](https://nextjs.org/docs/app/api-reference/cli/create-next-app). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you replace this README with some relevant content? I know this is just a starting point, but now is as good a time as later, and you can then add to it and amend as you go along.
e.g. keep the "Getting Started" section, but add a bit of stuff about what pages to expect (just one main page at this stage?) and what is implemented, i.e. Auth, what ENV vars you need, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe even a screenshot would be nice, and can update as the design matures.
|
||
it('renders the Header component', () => { | ||
render(<HomePage />); | ||
expect(screen.getByTestId('mock-header')).toBeInTheDocument(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I usually use Cypress but this works too!
Pull Request
Description
Please delete the italicised instruction text!
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: