Skip to content

build(deps): refresh workspace dependencies - #40

Merged
steipete merged 3 commits into
mainfrom
chore/dependency-refresh-2026-07-27
Jul 27, 2026
Merged

build(deps): refresh workspace dependencies#40
steipete merged 3 commits into
mainfrom
chore/dependency-refresh-2026-07-27

Conversation

@steipete

Copy link
Copy Markdown
Contributor

Summary

The deliberate sharp@<0.35.0 override and blocked Sharp build script are unchanged.

Proof

  • Node 24.18.0 and pnpm 11.2.2
  • pnpm lint
  • pnpm typecheck
  • pnpm test (186 tests passed)
  • admin and demo production builds
  • documentation build (17 pages)
  • wrangler deploy --dry-run
  • pnpm audit --audit-level=high (no known vulnerabilities)
  • pnpm outdated -r --format json (no eligible updates)
  • structured autoreview: clean, no accepted/actionable findings

The CLI timeout failure reproduced twice before the test-boundary fix; the three affected process-heavy cases pass together afterward, and the complete CLI suite passes 47/47.

@steipete
steipete requested review from a team as code owners July 27, 2026 09:31
@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. merge-risk: 🚨 automation 🚨 Merging this PR could break CI, automerge, proof capture, label sync, or automation. labels Jul 27, 2026
@clawsweeper

clawsweeper Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codex review: needs real behavior proof before merge. Reviewed July 27, 2026, 5:39 AM ET / 09:39 UTC.

ClawSweeper review

What this changes

The branch refreshes direct workspace dependencies, updates four pinned GitHub Actions revisions, regenerates the pnpm lockfile, and increases CLI subprocess-test timeouts.

Merge readiness

Blocked until stronger real behavior proof is added - 5 items remain

Keep this PR open for ordinary review: it consolidates several pending dependency updates and the supplied checks are green, but the external-PR proof gate is not met by summarized command claims alone. The only concrete patch adjustment is to leave the release-owned changelog entry out of this normal dependency PR.

Priority: P3
Reviewed head: d514eaf83d485b3454f4eb7a027f44e4b91596eb

Review scores

Measure Result What it means
Overall readiness 🦪 silver shellfish (2/6) The patch is focused and supplied CI is green, but inspectable real after-fix behavior proof is still missing for an external PR.
Proof confidence 🦪 silver shellfish (2/6) Needs stronger real behavior proof before merge: The PR body summarizes successful commands and test counts, but it does not provide inspectable after-fix terminal output, logs, recording, or linked artifact for the exact head. Before merge, attach redacted runtime evidence for the CLI timeout cases and affected builds; updating the PR body should trigger review, or a maintainer can comment @clawsweeper re-review. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Patch quality 🐚 platinum hermit (4/6) 1 actionable review finding remain.

Verification

Check Result Evidence
Real behavior Needs proof Needs stronger real behavior proof before merge: The PR body summarizes successful commands and test counts, but it does not provide inspectable after-fix terminal output, logs, recording, or linked artifact for the exact head. Before merge, attach redacted runtime evidence for the CLI timeout cases and affected builds; updating the PR body should trigger review, or a maintainer can comment @clawsweeper re-review. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Evidence reviewed 4 items Dependency and workflow scope: The provided branch diff updates four workflow action pins, five package manifests, the Biome schema, CLI test timing, a release-owned changelog entry, and the lockfile.
CLI timing change: The branch increases the subprocess timeout from 3 seconds to 10 seconds and the enclosing test-suite timeout to 20 seconds after reporting two loaded-runner timeout reproductions.
Workflow pin update: The branch keeps GitHub Actions pinned by full commit SHA while moving checkout and CodeQL to the revisions described in the dependency-update context.
Findings 1 actionable finding [P3] Remove the release-owned changelog entry
Security None None.

How this fits together

Krillswitch’s admin UI, API worker, demo, CLI, and shared packages consume versions from workspace manifests and pnpm-lock.yaml; GitHub Actions then run those tools in CI and deployments. This PR changes the resolved runtime/tooling set and the test timing boundary used to validate the CLI.

flowchart LR
  Manifests[Workspace package manifests] --> Resolution[pnpm dependency resolution]
  Resolution --> Lockfile[pnpm lockfile]
  Lockfile --> Services[Admin UI, API, demo, CLI]
  Services --> Checks[Build, typecheck, tests]
  WorkflowPins[GitHub Action pins] --> Checks
  Checks --> Deploy[Deployment workflow]
Loading

Before merge

  • Add real behavior proof - Needs stronger real behavior proof before merge: The PR body summarizes successful commands and test counts, but it does not provide inspectable after-fix terminal output, logs, recording, or linked artifact for the exact head. Before merge, attach redacted runtime evidence for the CLI timeout cases and affected builds; updating the PR body should trigger review, or a maintainer can comment @clawsweeper re-review. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
  • Remove the release-owned changelog entry (P3) - CHANGELOG.md is release-owned in this repository’s review policy, so this ordinary dependency PR should not add a release note. Keep the security-upgrade context in the PR body or commit message and let release management curate the changelog.
  • Resolve merge risk (P1) - React Router, authentication, Cloudflare tooling, and the lockfile all change together; CI is green, but maintainers should retain explicit upgrade review for the admin/API paths.
  • Resolve merge risk (P1) - Four CI/deployment workflows move to new action revisions, so a normal post-merge workflow run remains the practical automation compatibility check.
  • Complete next step (P2) - Maintainer review should verify the dependency/automation upgrade surface after the contributor supplies real exact-head behavior proof; there is no safe automated repair lane for contributor-environment proof.

Findings

  • [P3] Remove the release-owned changelog entry — CHANGELOG.md:13
Agent review details

Security

None.

Review metrics

Metric Value Why it matters
Changed surface 13 files; 814 additions, 697 deletions Most churn is lockfile resolution, but the PR also changes runtime manifests, test timing, and CI workflow pins.
Workflow revisions 4 workflow files changed Checkout and CodeQL pin changes affect CI and deployment execution independently of application tests.

Merge-risk options

Maintainer options:

  1. Keep the upgrade narrow and evidence-backed (recommended)
    Remove the release-owned changelog entry, attach redacted exact-head runtime output for the CLI timeout path and builds, then merge after a maintainer confirms the dependency upgrade surface.
  2. Split the dependency refresh
    If maintainers want lower upgrade blast radius, keep the React Router security update in a narrow PR and defer the broader tooling refresh.
  3. Pause for a refreshed dependency batch
    Close or pause this branch only if a newer, equally well-validated dependency consolidation replaces it.

Technical review

Best possible solution:

Land the consolidated dependency update after removing the release-owned CHANGELOG.md change and attaching redacted, after-fix terminal or live-output evidence from the exact head for the CLI suite and affected production builds; let release management decide if and when to note the security update.

Do we have a high-confidence way to reproduce the issue?

Yes for the reported test-flake boundary: the changed CLI helper shows the former 3-second kill timer and the branch identifies the affected process-heavy cases. The supplied context does not include independently inspectable failing and passing runtime output from the exact head.

Is this the best way to solve the issue?

Mostly yes: consolidating overlapping dependency PRs reduces lockfile and merge-conflict churn, and the timeout change is narrowly scoped to subprocess-heavy tests. The release-owned changelog entry should not be part of a normal PR, and real after-fix evidence is still needed before merge.

Full review comments:

  • [P3] Remove the release-owned changelog entry — CHANGELOG.md:13
    CHANGELOG.md is release-owned in this repository’s review policy, so this ordinary dependency PR should not add a release note. Keep the security-upgrade context in the PR body or commit message and let release management curate the changelog.
    Confidence: 0.96

Overall correctness: patch is correct
Overall confidence: 0.76

AGENTS.md: unclear because the file could not be read completely.

Codex review notes: model internal, reasoning high; reviewed against 6c0091e86883.

Labels

Label changes:

  • add P3: This is routine dependency and build-maintenance work with successful supplied CI, not a reported production outage.
  • add merge-risk: 🚨 compatibility: The PR simultaneously updates UI routing, auth-adjacent packages, Cloudflare tooling, and their resolved dependency graph.
  • add merge-risk: 🚨 automation: Four GitHub workflow files change pinned action revisions that execute CI and deployment jobs after merge.
  • add rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🐚 platinum hermit.
  • add status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs stronger real behavior proof before merge: The PR body summarizes successful commands and test counts, but it does not provide inspectable after-fix terminal output, logs, recording, or linked artifact for the exact head. Before merge, attach redacted runtime evidence for the CLI timeout cases and affected builds; updating the PR body should trigger review, or a maintainer can comment @clawsweeper re-review. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Label justifications:

  • P3: This is routine dependency and build-maintenance work with successful supplied CI, not a reported production outage.
  • merge-risk: 🚨 compatibility: The PR simultaneously updates UI routing, auth-adjacent packages, Cloudflare tooling, and their resolved dependency graph.
  • merge-risk: 🚨 automation: Four GitHub workflow files change pinned action revisions that execute CI and deployment jobs after merge.
  • rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🐚 platinum hermit.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs stronger real behavior proof before merge: The PR body summarizes successful commands and test counts, but it does not provide inspectable after-fix terminal output, logs, recording, or linked artifact for the exact head. Before merge, attach redacted runtime evidence for the CLI timeout cases and affected builds; updating the PR body should trigger review, or a maintainer can comment @clawsweeper re-review. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Evidence

What I checked:

  • Dependency and workflow scope: The provided branch diff updates four workflow action pins, five package manifests, the Biome schema, CLI test timing, a release-owned changelog entry, and the lockfile. (pnpm-lock.yaml:1, d514eaf83d48)
  • CLI timing change: The branch increases the subprocess timeout from 3 seconds to 10 seconds and the enclosing test-suite timeout to 20 seconds after reporting two loaded-runner timeout reproductions. (packages/cli/test/cli.test.ts:36, d514eaf83d48)
  • Workflow pin update: The branch keeps GitHub Actions pinned by full commit SHA while moving checkout and CodeQL to the revisions described in the dependency-update context. (.github/workflows/codeql.yml:37, d514eaf83d48)
  • Related pending work: The PR body explicitly absorbs overlapping updates from four still-open dependency PRs, including the React Router security update; none is merged, so this PR remains a viable consolidation path rather than already-implemented work. (apps/admin/package.json:18, d514eaf83d48)

Likely related people:

  • steipete: The three commits on this branch combine workspace dependency maintenance, CLI test-boundary handling, and the dependency-security note; current-main ownership history could not be established from the available read-only inspection environment. (role: recent dependency-update contributor; confidence: low; commits: f3e028867797, b9cebab4f401, d514eaf83d48; files: apps/admin/package.json, apps/api/package.json, packages/cli/test/cli.test.ts)

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Remove the CHANGELOG.md entry from this normal PR.
  • Attach redacted exact-head terminal or live output showing the affected CLI cases and production builds after the timeout change.

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper

clawsweeper Bot commented Jul 27, 2026

Copy link
Copy Markdown

ClawSweeper status: review started.

I am starting a fresh review of this pull request: build(deps): refresh workspace dependencies This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@steipete

Copy link
Copy Markdown
Contributor Author

Admin bypass authorized by Peter for this landing because the only remaining blocker is the required-review rule and self-approval is unavailable.

Exact head: d514eaf83d485b3454f4eb7a027f44e4b91596eb

All required hosted checks are green, and the final branch-wide autoreview completed clean with no accepted/actionable findings. Proceeding with the authorized administrator merge.

@steipete
steipete merged commit bdd7bb6 into main Jul 27, 2026
12 checks passed
@steipete
steipete deleted the chore/dependency-refresh-2026-07-27 branch July 27, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk: 🚨 automation 🚨 Merging this PR could break CI, automerge, proof capture, label sync, or automation. merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant