fix(docs): render markdown strikethrough#706
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 7, 2026, 1:44 AM ET / 05:44 UTC. Summary Reproducibility: yes. from source inspection and the linked report: current main's local markdown writer parses bold/italic/code/link but has no strikethrough field or request emission, matching the reported literal tilde output. I did not run live Google commands during this read-only review. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge
Security Review detailsBest possible solution: Review and land this focused PR if maintainers accept the exact two-tilde GFM behavior and the reported live Google proof. Do we have a high-confidence way to reproduce the issue? Yes from source inspection and the linked report: current main's local markdown writer parses bold/italic/code/link but has no strikethrough field or request emission, matching the reported literal tilde output. I did not run live Google commands during this read-only review. Is this the best way to solve the issue? Yes. Extending the existing inline parser and AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against f0dbde21f892. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Landed in 490a9cb. Tested with:
|
Summary
~~strikethrough~~spans in the local markdown writertextStyle.strikethroughupdate requests for parsed spans~~~text~~~literal to avoid eating unsupported markdownFixes #702.
Proof
go test ./internal/cmd -run 'TestParseInlineFormatting|TestMarkdownToDocsRequests_Strikethrough|TestMarkdownToDocsRequests_BaseIndex|TestMarkdownToDocsRequests_AppendBulletsAndCode'go test ./internal/cmd/...make ciclawdbot@gmail.com: scratch Doc1GNjuLeCXtmNVQAyw0c7XOdLjGIv-p6f9VR21dDfrkY0, tabt.eyzzzc9zen2h; whole-doc write reportedwhole_strike:trueandwhole_tilde_markers:0; tab write reportedtab_strike:trueandtab_tilde_markers:0; cleanup reportedcleanup_trashed:true.