fix(runtime): upgrade SkillSpector to 2.11.2 - #52
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed September 10, 2026, 12:27 AM ET / 04:27 UTC (Revision 2). ClawSweeper reviewWhat this changesUpdates the Docker runtime’s pinned SkillSpector scanner to 2.11.2, bringing a longer analysis deadline and parser and reference-accounting fixes. Merge readiness⛔ Blocked before merge - 3 items remain This remains useful work: main and v0.1.7 retain the older pin, and the packaged scan evidence supports compatibility with ClawScan’s adapter. No actionable patch defect was found; the repository’s benchmark-based runtime upgrade gate remains outstanding. Priority: P2 Review scores
Verification
How this fits togetherClawScan invokes SkillSpector inside its default Docker runtime to inspect skill files. The adapter preserves the scanner’s JSON evidence for reports, configured gates, and optional external judges. flowchart LR
A[Skill files] --> B[ClawScan scanner adapter]
B --> C[Docker runtime]
C --> D[SkillSpector analysis]
D --> E[Raw JSON evidence]
E --> F[Reports and configured gates]
E --> G[Optional external judge]
Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Retain the focused immutable-pin upgrade with benchmark evidence showing acceptable verdict, failure-rate, and runtime changes for existing profiles. Do we have a high-confidence way to reproduce the issue? No high-confidence reproduction of the original timeout was established: the supplied baseline runs completed without runtime-limit exceptions. The forced-budget run demonstrates the deadline mechanism, rather than reproducing the original failure. Is this the best way to solve the issue? Yes, updating the existing immutable dependency pin is the narrowest integration path; the remaining acceptance work is the repository’s runtime benchmark comparison. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 6432c40f2340. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
Summary
Upgrade the Docker runtime's immutable SkillSpector pin to 2.11.2 (
69dcdfb74487d361ba4c811d088cfdea2ff3a9dc). This includes the configurable aggregate deadline with a 600-second default from NVIDIA/SkillSpector#468, plus the 2.11.2 reference-accounting and parser fixes. This is the only change intended for ClawScan 0.1.8.Scope
Security / Trust Impact
The scanner receives more time to inspect large skills. Raw findings and incomplete-analysis evidence are preserved; no findings are suppressed.
Verification
go test -count=1 ./...go vet ./...node --test npm/clawscan/test/*.test.mjs scripts/build-npm-package.test.mjsnode scripts/build-npm-package.mjs --version v0.1.8 --pack --smokeLive proof on
byungkyu/api-gateway@1.2.0, downloaded from the owner-qualified ClawHub API. Every published file matched its API SHA-256. The current export has 236 published files (the original 235 plus a generatedskill-card.md); export-only_meta.jsonwas excluded. All scans used--no-llmand an isolated environment with no model credentials.The timeout override works, and the default-budget run avoids runtime-limit/AE1 findings. The original 2.11.0 timeout did not reproduce on this Mac. The latest report remains partial with 186 unresolved-reference exceptions, one reference-extraction limit, and two obfuscated-text exceptions; it still reports 599 findings and CRITICAL / DO_NOT_INSTALL. This update does not claim to fix those independent scanner limits or ClawHub's completeness-reporting bug.
Packaged Linux/arm64 verification also passed using the built ClawScan 0.1.8 candidate and the complete runtime Dockerfile. The wrapper recorded SkillSpector 2.11.2 as
completed, preserving its raw partial report (99.2% coverage, no runtime-limit exceptions) in 65.94s. The same container stack with only SkillSpector reverted to 2.11.0 completed in 17.73s with 99.6% coverage and no runtime-limit exceptions. Both wrapper runs exited 0; SkillSpector itself exited 1 for findings. Neither result is presented as a clean or complete security scan.