- 
                Notifications
    You must be signed in to change notification settings 
- Fork 941
fix out of range in semi_sync_master_timeout #1207
fix out of range in semi_sync_master_timeout #1207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, a couple changes requested
| (you can see all CI jobs failed -- that's because of the  | 
Co-authored-by: Shlomi Noach <[email protected]>
Co-authored-by: Shlomi Noach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to further change the matching go variable to int64 or uint64, correct? Let's do this in this PR, too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think last requested changes
| 
 I didn't do  | 
| 
 Whoops. But I think we must use it, right? Because the value reported is  | 
| I know why  | 
| I wonder if we should literally first compare the string with  | 
| 
 !!! The name confused me, I assumed it returns a  | 
| See #1209 | 
| 
 | 
| 
 Yeah, I'm 💯 👍 on that.  | 
Solves issue: #1205
Description
This PR sets
semi_sync_master_timeoutasbigintto avoid out of range (overflow) errors.