Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize uploader #20

Open
wants to merge 50 commits into
base: develop
Choose a base branch
from
Open

Finalize uploader #20

wants to merge 50 commits into from

Conversation

nbumbarger
Copy link
Collaborator

Combine four PRs to update develop branch.

  • Convert layout to match wireframes.
  • Add success and failure messages.
  • Add better validation summary information.
  • Add e-mail field and attaches e-mail column to CSV data.
  • Add form validation.
  • Add instructions/ schema definition modal.

@danielfdsilva
Copy link
Contributor

@nbumbarger

  • Form clears well on cancel
  • When the submission errors because of an invalid token, the Try Again button resubmits the form which will never work. This should be handled in a different way. Maybe redirect to the 1st step?
  • If I try to submit data with a valid token, the call to https://api.openaq-staging.org/v1/upload returns 200 but I still get the "Uploader Error" screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants