fix(client): treat empty OPENAI_BASE_URL as unset#2952
Open
mvanhorn wants to merge 1 commit intoopenai:mainfrom
Open
fix(client): treat empty OPENAI_BASE_URL as unset#2952mvanhorn wants to merge 1 commit intoopenai:mainfrom
mvanhorn wants to merge 1 commit intoopenai:mainfrom
Conversation
When OPENAI_BASE_URL is set to an empty string, os.environ.get() returns "" instead of None, preventing the fallback to the default API endpoint. Use `or None` to treat empty strings as missing. Fixes openai#2927 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2927
Problem
When
OPENAI_BASE_URLis set to an empty string (e.g.,OPENAI_BASE_URL=""),os.environ.get("OPENAI_BASE_URL")returns""instead ofNone. The subsequentif base_url is Nonecheck passes, so the client uses an empty string as the base URL instead of falling back tohttps://api.openai.com/v1.Fix
Use
or Noneto normalize empty strings toNone, allowing the default fallback to trigger correctly. Applied to bothOpenAIandAsyncOpenAIconstructors.Tests
Added
test_base_url_env_empty_stringfor both sync and async clients, verifying that an emptyOPENAI_BASE_URLfalls back to the default endpoint.This contribution was developed with AI assistance (Claude Code).