Add defaults for type fields in types.beta.realtime and support open str type for session.model
#2479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is consistent with voice field now and it allows more flexibilty between client and server versions
Makes it cleaner to programmatically construct events if needed The type fields were previously required to construct, but only accepted one possible value, so it was unneeded verbosity Done with automated find/replace in realtime folder: type: Literal\["([\w\.]+)"\] type: Literal["$1"] = "$1"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Add defaults for
typefields in types.beta.realtimeThis makes it simpler and cleaner to programmatically construct events for more complex client flows - the type is redundant with class name in practice.
Add
strfallback for SessionUpdateEvent.session.model fieldThis makes it more flexible to use different client and server versions as things evolve over time. And it's consistent with how
voicefield is handled.Additional context & links