Skip to content

feat: reject emitted promise on error in EventEmitter #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: reject emitted promise on error in EventEmitter #1596

wants to merge 2 commits into from
+34 −1

Conversation

bigint
Copy link
Contributor

@bigint bigint commented Jul 23, 2025

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

  • Implemented rejection logic in EventEmitter.emitted so that if an “error” occurs before the target event, the returned Promise now rejects accordingly
  • Added a dedicated test suite for EventEmitter.emitted to verify both successful resolution and rejection when an “error” event precedes the target event

Additional context & links

@bigint bigint requested a review from a team as a code owner July 23, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bigint