Repository navigation
chore(api): preserve next API compatibility - #1291
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf91fa4958
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed all 24 changed paths at bf91fa49580d. The public patch exactly matches the reviewed generation, and the request/schema support paths are unchanged.
The existing unused-validator thread identifies the structural issue: 1,032 lines of quota implementation, resource and tests have no active SDK caller. For this compatibility-preserving cleanup, have the generator omit those artifacts and their inventory entries. Wiring new request rejection into this PR would expand its scope.
The old class-derived schema limits are inherited behavior, not a new regression. The stale contributor guidance should also be corrected as part of retiring the checker.
Source-only review with an independent pass; no tests, builds or generation ran here. Hosted CI is still finishing.
The next contributor guidance currently says this revision retains the legacy Castiron checker and reporting workflows. Canonical regeneration removes those files, leaving that wording stale. Describe the transition in terms of the actual checkout: preserve checks while the legacy tooling exists, retire it through regeneration, and inspect hosted workflow settings and repository rules separately. This changes only AGENTS.md and CONTRIBUTING.md; generated-file ownership and required-check protections remain intact. This public-owned documentation prerequisite addresses the guidance concern in #1291. That generated promotion will refresh onto this baseline after merge. Validation: reviewed both complete diffs, checked unchanged policy links and headings, and ran git diff --check. No runtime or workflow changes.
bf91fa4 to
5056874
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 505687403c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed all 21 changed paths at 505687403c82376618213901dd342155a1735c0b. The 19 retired files match the inventory removals; all 3,987 retained entries are unchanged. The old unused quota implementation, resource and tests are absent. Contributor guidance now distinguishes source retirement from hosted checks. No SDK runtime, API schema or dependency changes appear in this diff.
The three earlier findings are addressed. The existing security-model comment remains a valid low-priority documentation correction, tracked separately in #1295; I have not duplicated it. It does not introduce a runtime regression or a new privilege boundary.
Source-only review with an independent pass; no local tests, builds or generation ran. Hosted lint, build and runtime compatibility checks passed at the last check; the remaining SDK and compatibility checks were still running.
The security model currently assumes the legacy publisher always exists, which becomes false after canonical next regeneration. Make that boundary conditional on the workflow and publisher files in the reviewed revision. Preserve its threat hypothesis and privileged-status controls while present; explicitly retire that component after deletion and retain the separate hosted-rules warning. This documentation baseline supports #1291 without changing runtime, dependencies, workflows, release controls, or disclosure policy. Validation: basic review of the complete one-file diff and `git diff --check`. Both pre-removal and post-removal cases are explicitly covered.
Castiron-Internal-PR: openai/openai-java-internal#380 Castiron-Source-SHA: 1188640d4283f63d9e66e0c80e0f532f147e791a Castiron-Public-Base-SHA: 78da57a
695a211
5056874 to
695a211
Compare
Summary
Preserves the existing next API definitions and configuration.
Changes