Repository navigation
build: bump com.squareup.okhttp3:okhttp in /openai-java-bedrock - #1227
dependabot[bot] wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 0 mixed files remain; 0 existing customizations changed. Compared A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 40530960661 --repo openai/openai-java \
--name castiron-custom-code-40530960661-1 --dir /tmp/castiron-custom-code-40530960661-1
git apply --stat /tmp/castiron-custom-code-40530960661-1/custom-code.patch
cat /tmp/castiron-custom-code-40530960661-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 014f4a2dbb1f2b13655589fe83ba6ef5af4e18b5 ff620a50ef8b32296cef754f9e098188b365ebd5
python3 scripts/castiron/custom_code_report.py report \
--base 014f4a2dbb1f2b13655589fe83ba6ef5af4e18b5 \
--head ff620a50ef8b32296cef754f9e098188b365ebd5 --target-branch main --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-ff620a50ef8b
cat /tmp/castiron-custom-code-ff620a50ef8b/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f37150ceb1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| api(project(":openai-java-core")) | ||
|
|
||
| implementation("com.squareup.okhttp3:okhttp:4.12.0") | ||
| implementation("com.squareup.okhttp3:okhttp:5.5.0") |
There was a problem hiding this comment.
Depend on the JVM artifact for Maven consumers
OkHttp 5 publishes com.squareup.okhttp3:okhttp as a multiplatform metadata artifact: Gradle follows its module metadata to okhttp-jvm, but Maven receives an effectively empty JAR whose POM does not redirect to the JVM artifact. Because this declared coordinate is retained in the SDK's generated POM, Maven users of openai-java-client-okhttp (and transitively openai-java-bedrock) will get NoClassDefFoundError for okhttp3 classes when building the client. Use com.squareup.okhttp3:okhttp-jvm:5.5.0 for the published JVM modules, or explicitly rewrite the published POM and cover Maven consumption.
AGENTS.md reference: AGENTS.md:L34-L36
Useful? React with 👍 / 👎.
| api(project(":openai-java-core")) | ||
|
|
||
| implementation("com.squareup.okhttp3:okhttp:4.12.0") | ||
| implementation("com.squareup.okhttp3:okhttp:5.5.0") |
There was a problem hiding this comment.
Add the required OkHttp 5 migration ADR
This changes the transport from the OkHttp 4 dependency generation to OkHttp 5, but the commit contains only coordinate updates and a repo-wide search under docs/ finds no corresponding decision record. docs/version-support-policy.md:60-62 requires every material dependency-generation change to have an ADR covering lifecycle evidence, affected artifacts, consumer resolution, migration, SemVer treatment, the final compatible release, and verification; add that ADR before landing this major-generation upgrade.
Useful? React with 👍 / 👎.
Bumps [com.squareup.okhttp3:okhttp](https://github.com/lysine-dev/okhttp) in `/openai-java-bedrock` from 4.12.0 to 5.5.0. Updates `com.squareup.okhttp3:okhttp` from 4.12.0 to 5.5.0 - [Changelog](https://github.com/lysine-dev/okhttp/blob/main/CHANGELOG.md) - [Commits](lysine-dev/okhttp@parent-4.12.0...parent-5.5.0) Updates `com.squareup.okhttp3:okhttp` from 4.12.0 to 5.5.0 - [Changelog](https://github.com/lysine-dev/okhttp/blob/main/CHANGELOG.md) - [Commits](lysine-dev/okhttp@parent-4.12.0...parent-5.5.0) --- updated-dependencies: - dependency-name: com.squareup.okhttp3:okhttp dependency-version: 5.5.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: sdk-dependencies/com.squareup.okhttp3:okhttp - dependency-name: com.squareup.okhttp3:okhttp dependency-version: 5.5.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: sdk-dependencies/com.squareup.okhttp3:okhttp ... Signed-off-by: dependabot[bot] <support@github.com>
f37150c to
ff620a5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff620a50ef
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| api(project(":openai-java-core")) | ||
|
|
||
| api("com.squareup.okhttp3:okhttp:4.12.0") | ||
| api("com.squareup.okhttp3:okhttp:5.5.0") |
There was a problem hiding this comment.
Avoid forcing Android consumers onto compileSdk 37
For Gradle Android consumers, this multiplatform coordinate now selects okhttp-android:5.5.0, whose AAR metadata requires compileSdk 37; applications still compiling against API 36 or earlier therefore fail checkDebugAarMetadata merely by upgrading this SDK. OkHttp's 5.x changelog confirms that Gradle selects a separate Android artifact and that 5.5.0 adds API-37-specific platform support. Preserve an Android-compatible version or explicitly treat and test this as an Android build-floor increase; the current JVM-only compatibility probes select okhttp-jvm and cannot detect it.
Useful? React with 👍 / 👎.
Bumps com.squareup.okhttp3:okhttp in
/openai-java-bedrockfrom 4.12.0 to 5.5.0.Updates
com.squareup.okhttp3:okhttpfrom 4.12.0 to 5.5.0Changelog
Sourced from com.squareup.okhttp3:okhttp's changelog.
... (truncated)
Commits
a94bdf1Prepare for release 5.5.0.ecc3b05Use a fixed size for DoH request body (#9687)9926082Revert "Use a fixed size for DoH request body" (#9686)0070c2eUse a fixed size for DoH request body1576453Order ServiceMetadata records per the spec (#9683)fb582e9Flip wiring of Dns.SYSTEM (#9682)4e884abretryOnConnectionFailure doesn't impact ECH retries (#9681)0433ceeOnly one contributing.md doc (#9678)a2cf5aaDon't recover after an ECH public_name fails to verify (#9680)5410de9Test ECH + HTTP proxy (#9671)Updates
com.squareup.okhttp3:okhttpfrom 4.12.0 to 5.5.0Changelog
Sourced from com.squareup.okhttp3:okhttp's changelog.
... (truncated)
Commits
a94bdf1Prepare for release 5.5.0.ecc3b05Use a fixed size for DoH request body (#9687)9926082Revert "Use a fixed size for DoH request body" (#9686)0070c2eUse a fixed size for DoH request body1576453Order ServiceMetadata records per the spec (#9683)fb582e9Flip wiring of Dns.SYSTEM (#9682)4e884abretryOnConnectionFailure doesn't impact ECH retries (#9681)0433ceeOnly one contributing.md doc (#9678)a2cf5aaDon't recover after an ECH public_name fails to verify (#9680)5410de9Test ECH + HTTP proxy (#9671)