Add protocol method support for Video APIs #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hreja_VideosAPI
joseharriaga
approved these changes
Oct 24, 2025
| public virtual ClientResult GetVideo(string videoId, RequestOptions options = null); | ||
| public virtual Task<ClientResult> GetVideoAsync(string videoId, RequestOptions options = null); | ||
| public virtual ClientResult GetVideos(long? limit = null, string order = null, string after = null, RequestOptions options = null); | ||
| public virtual Task<ClientResult> GetVideosAsync(long? limit = null, string order = null, string after = null, RequestOptions options = null); |
There was a problem hiding this comment.
"GetVideos" and "GetVideosAsync" should implement the pagination pattern. As an example, you can take a look at the ContainerClient:
🔗 https://github.com/openai/openai-dotnet/blob/main/api/OpenAI.net8.0.cs#L2429
This is Chris's PR:
🔗 #624
We don't need to block the release on this, so we can add it in a separate PR. 🙂
There was a problem hiding this comment.
I have created an issue for this: #776
|
|
||
| Console.WriteLine($"CreateVideo => id: {id}, status: {status}"); | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds protocol methods for the Video APIs.
Docs ref: https://platform.openai.com/docs/api-reference/videos