Skip to content

fix: reduce sandbox sink buffering and spool timeouts#3642

Merged
seratch merged 1 commit into
openai:mainfrom
2830500285:codex/fix-sandbox-sink-flush-spool
Jun 22, 2026
Merged

fix: reduce sandbox sink buffering and spool timeouts#3642
seratch merged 1 commit into
openai:mainfrom
2830500285:codex/fix-sandbox-sink-flush-spool

Conversation

@2830500285

Copy link
Copy Markdown
Contributor

Summary

  • keep WorkspaceJsonlSink memory bounded to pending events by reading the existing workspace outbox during flush and clearing pending bytes after a successful write
  • preserve existing workspace JSONL contents across repeated flushes without duplicating lines
  • spool HttpProxySink events when urlopen raises a direct timeout/OSError delivery failure

Test plan

  • uv run pytest tests/sandbox/test_session_sinks.py -q -k "clears_flushed_buffer or spools_direct_timeout"
  • uv run pytest tests/sandbox/test_session_sinks.py -q
  • make sync
  • UV_PROJECT_ENVIRONMENT=.venv_314 make sync
  • UV_PROJECT_ENVIRONMENT=.venv_314 bash .agents/skills/code-change-verification/scripts/run.sh

Issue number

Closes #3640
Closes #3641

Checks

  • I have added new tests (if relevant)
  • I have added/updated the relevant documentation
  • I have run make lint and make format
  • I have made sure tests pass

@seratch seratch merged commit f115dd6 into openai:main Jun 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HttpProxySink timeout failures can skip the configured spool fallback WorkspaceJsonlSink keeps flushed event bytes in memory for the whole session

2 participants