Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant weaker tracing assertions #261

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alexmojaki
Copy link
Contributor

Following up on #25, this removes uses of fetch_traces and fetch_ordered_spans where there's already a stronger assertion using fetch_normalized_spans. This is to help move towards the stronger style as much as possible, since people are still adding weaker assertions such as this in #91. The next step will be to find remaining uses of fetch_ordered_spans that can be replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant