-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix: Properly await cancelled tasks in voice result streaming cleanup #1978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gn00295120
wants to merge
6
commits into
openai:main
Choose a base branch
from
gn00295120:fix-voice-result-task-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a52d0c9
Fix voice result streaming task cleanup to properly await cancelled t…
gn00295120 7e4dfca
Remove unnecessary try-except for CancelledError in _check_errors
gn00295120 7198e3c
Preserve exceptions from gather() during task cleanup
gn00295120 0de9629
Merge branch 'main' into fix-voice-result-task-cleanup
gn00295120 ab6effd
Merge branch 'main' into fix-voice-result-task-cleanup
gn00295120 72ab08b
Merge branch 'main' into fix-voice-result-task-cleanup
gn00295120 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.