-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add Dapr session storage option #1937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…akefile for test commands - Added DaprSession class for managing sessions with Dapr state stores, supporting various backends like Redis and PostgreSQL. - Updated Makefile to include separate targets for unit tests, integration tests, and all tests. Signed-off-by: Filinto Duran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Filinto Duran <[email protected]>
…istency values Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
…ge test cases Signed-off-by: Filinto Duran <[email protected]>
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
…o reduce grpc warning Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't be able to take time to thoroughly review the changes and behavior for a while, but here are my quick requests.
@seratch thanks, I'll take care of the docs notes. In relation to the integration tests, I could move to a separate folder just for integration tests so running them can be done by specifying the folder, or I could add running guards, like if import dapr/testcontainers does not fail and and docker is present run it. Let me know what would you prefer |
Just skipping the integration tests when the prerequisites are not ready should be good to go 👍 |
Signed-off-by: Filinto Duran <[email protected]>
@seratch all items requested completed for when you have time. thanks |
Signed-off-by: Filinto Duran <[email protected]>
…o-close Signed-off-by: Filinto Duran <[email protected]>
This comment was marked as off-topic.
This comment was marked as off-topic.
Signed-off-by: Filinto Duran <[email protected]>
…containers, also show postgresql and redis at the same time Signed-off-by: Filinto Duran <[email protected]>
Implement DaprSession for distributed session management and update makefile for test commands.
Dapr makes it easy to integrate with many different DB as shown in https://docs.dapr.io/reference/components-reference/supported-state-stores