Skip to content

Conversation

filintod
Copy link
Contributor

Implement DaprSession for distributed session management and update makefile for test commands.

Dapr makes it easy to integrate with many different DB as shown in https://docs.dapr.io/reference/components-reference/supported-state-stores

  • Added DaprSession class for managing sessions with Dapr state stores, supporting various backends like Redis and PostgreSQL.
  • Updated Makefile to include separate targets for unit tests, integration tests, and all tests.

…akefile for test commands

- Added DaprSession class for managing sessions with Dapr state stores, supporting various backends like Redis and PostgreSQL.
- Updated Makefile to include separate targets for unit tests, integration tests, and all tests.

Signed-off-by: Filinto Duran <[email protected]>
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@seratch seratch added enhancement New feature or request feature:sessions labels Oct 20, 2025
@filintod
Copy link
Contributor Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't be able to take time to thoroughly review the changes and behavior for a while, but here are my quick requests.

@filintod
Copy link
Contributor Author

@seratch thanks, I'll take care of the docs notes. In relation to the integration tests, I could move to a separate folder just for integration tests so running them can be done by specifying the folder, or I could add running guards, like if import dapr/testcontainers does not fail and and docker is present run it. Let me know what would you prefer

@seratch
Copy link
Member

seratch commented Oct 21, 2025

I could add running guards, like if import dapr/testcontainers does not fail and and docker is present run it. Let me know what would you prefer

Just skipping the integration tests when the prerequisites are not ready should be good to go 👍

Signed-off-by: Filinto Duran <[email protected]>
@filintod filintod requested a review from seratch October 21, 2025 03:01
@filintod
Copy link
Contributor Author

@seratch all items requested completed for when you have time. thanks

@ProCityHub

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request feature:sessions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants