feat: Added error handling for CUDA device initialization #135
+62
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansschh
commented
Aug 15, 2025
ansschh
commented
- torch/utils.py: Added error handling to init_distributed() function
- CUDA availability check before initialization
- Validate rank against available device count
- Test device accessibility with clear error messages
- Handle distributed communication setup failures
- Clean up failed process groups
added 2 commits
August 9, 2025 11:25
- Add return type hint to get_tokenizer() - Add type hints and checkpoint validation to generate.py main() - Add parameter type hints to suppress_output() in torch/utils.py Improves IDE support and catches potential bugs early.
- Add CUDA availability check before device initialization - Validate rank against available CUDA device count - Add device accessibility testing with clear error messages - Add error handling for distributed communication setup - Add cleanup for failed distributed process group initialization - Provide helpful error messages with troubleshooting guidance This prevents cryptic CUDA errors and provides clear feedback when: - CUDA is not available - Invalid device rank is specified - Device access fails - Distributed communication fails
pg56714
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.