Add opt-in RTL compatibility for markdown rendering by omers-oai · Pull Request #63 · openai/compose-richtext

omers-oai · 2026-03-23T19:13:16Z

Codex:

Summary

add opt-in RichTextRenderOptions.enableRtlCompatibility for markdown paragraph and heading alignment on top of [codex] Extract RTL compatibility samples #66
keep behavior outside compatibility mode unchanged
align compatibility-mode paragraphs and headings by their first strong letter while leaving neutral-only text on the ambient side
update the RTL sample screen to opt into the compatibility mode

Testing

./gradlew :richtext-ui:allTests :richtext-markdown:allTests :android-sample:testDebugUnitTest

richtext-markdown/src/commonMain/kotlin/com/halilibo/richtext/markdown/BasicMarkdown.kt

richtext-markdown/src/commonMain/kotlin/com/halilibo/richtext/markdown/MarkdownRichText.kt

richtext-markdown/src/commonMain/kotlin/com/halilibo/richtext/markdown/TraverseUtils.kt

richtext-markdown/src/commonMain/kotlin/com/halilibo/richtext/markdown/BasicMarkdown.kt

richtext-markdown/src/commonMain/kotlin/com/halilibo/richtext/markdown/MarkdownRichText.kt

richtext-markdown/src/commonMain/kotlin/com/halilibo/richtext/markdown/TraverseUtils.kt

richtext-ui/src/commonMain/kotlin/com/halilibo/richtext/ui/FormattedList.kt

richtext-markdown/src/commonMain/kotlin/com/halilibo/richtext/markdown/BasicMarkdown.kt

richtext-markdown/src/commonMain/kotlin/com/halilibo/richtext/markdown/TraverseUtils.kt

rz-openai · 2026-03-27T17:22:55Z

richtext-markdown/src/commonMain/kotlin/com/halilibo/richtext/markdown/rtl/RtlCompatibility.kt

+ * Lets list and quote containers override paragraph alignment without forcing a different
+ * direction-detection rule for the text inside the item.


Curious why this is better than wrapping the Text with a different LocalLayoutDirection value?

I think LayoutDirection solves some of it but not all.
We have cases of an item in a list, which may be LTR or RTL, and the list itself (decide by first item) may have the list marked on the left or right. So we have both LTR and RTL text that we may need to align either left or right depending on the case.

rz-openai · 2026-03-27T17:32:54Z

richtext-markdown/src/commonMain/kotlin/com/halilibo/richtext/markdown/BasicMarkdown.kt

+  val markdownAnimationState = remember { MarkdownAnimationState() }
+
+  if (richTextRenderOptions.enableRtlCompatibility && astNode.type is AstDocument) {
+    BasicRichText(modifier = Modifier.width(IntrinsicSize.Max)) {


Would just using a Column here work? Seems like we have other simpler options available than putting another BasicRichText...

Oh... I had a long back and forth with Codex about this. It claimed it won't, I made it do it, and it ended up winning since it broke direction on some things and I didn't fully understand why, but it said we need to reset the lists and stuff so all items will be considered part of the same doc or something.

I do want to remove the duplicaiton here, should I extract a local Composable function? I'm not a fan too much of it.

I don't get it... why would we only need to reset lists if we want to change the RTL compatibility bit?

richtext-markdown/src/commonMain/kotlin/com/halilibo/richtext/markdown/BasicMarkdown.kt

rz-openai · 2026-03-27T18:47:15Z

richtext-markdown/src/commonMain/kotlin/com/halilibo/richtext/markdown/BasicMarkdown.kt


+      is AstUnorderedList,
      is AstOrderedList -> {
+        val items = remember(astNode) {


Looks like before we didn't remember this by astNode, I hope this doesn't break anything, I'm assuming it shouldn't....

omers-oai requested review from rjmarsan and rz-openai March 23, 2026 20:06

omers-oai marked this pull request as ready for review March 23, 2026 20:08

omers-oai mentioned this pull request Mar 24, 2026

Decouple RTL compatibility from width #64

Merged

omers-oai marked this pull request as draft March 24, 2026 21:06

omers-oai mentioned this pull request Mar 25, 2026

Narrow RTL compatibility width behavior #65

Closed

omers-oai force-pushed the codex/rtl-compatibility branch from 4d65c94 to c35efd3 Compare March 25, 2026 17:35

omers-oai changed the base branch from main to codex/rtl-compatibility-samples March 25, 2026 17:35

omers-oai force-pushed the codex/rtl-compatibility branch from c35efd3 to aa018ee Compare March 25, 2026 18:11

omers-oai added 2 commits March 25, 2026 14:19

Add opt-in RTL compatibility for markdown rendering

406149b

Minimize RTL compatibility mode changes

7aaf63a

omers-oai force-pushed the codex/rtl-compatibility branch from 93636e9 to 7aaf63a Compare March 25, 2026 18:20

omers-oai changed the base branch from codex/rtl-compatibility-samples to main March 25, 2026 18:20

omers-oai marked this pull request as ready for review March 26, 2026 17:31

Refine RTL compatibility rendering

49abd82

omers-oai commented Mar 26, 2026

View reviewed changes

omers-oai added 6 commits March 26, 2026 15:53

Address RTL compatibility review feedback

27f5d86

Simplify RTL compatibility follow-ups

5c2fcd2

Address latest RTL review comments

a6a4128

Tighten latest RTL review follow-ups

eedd096

Simplify latest BasicMarkdown review cleanup

3261d55

Move RTL sample code to stacked PR

f99d2ca

omers-oai mentioned this pull request Mar 27, 2026

[codex] Split RTL compatibility samples into stacked PR #68

Merged

omers-oai commented Mar 27, 2026

View reviewed changes

omers-oai added 6 commits March 26, 2026 20:29

Tighten latest RTL review simplifications

b0e3f62

Fix RTL compatibility code block direction detection

7722f3f

Remove first-line-only RTL compatibility detection

6265098

Refine paragraph-based RTL compatibility

acb1bff

Restore list item layout comment

fc34d8c

Move RTL compatibility helpers into rtl packages

00da845

omers-oai added 2 commits March 27, 2026 11:42

Document RTL compatibility helpers

b5aa8a2

Trim RTL helper KDoc

5cadd63

rz-openai reviewed Mar 27, 2026

View reviewed changes

richtext-markdown/src/commonMain/kotlin/com/halilibo/richtext/markdown/BasicMarkdown.kt Show resolved Hide resolved

omers-oai merged commit 0296d87 into main Mar 27, 2026
1 check passed

rz-openai reviewed Mar 27, 2026

View reviewed changes

		* Lets list and quote containers override paragraph alignment without forcing a different
		* direction-detection rule for the text inside the item.

Conversation

omers-oai commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rz-openai Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

omers-oai Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

rz-openai Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

omers-oai Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

omers-oai Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

rz-openai Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rz-openai Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

omers-oai commented Mar 23, 2026 •

edited

Loading