Skip to content

Conversation

@apanasenko-oai
Copy link
Collaborator

we are using developer instructions for code reviews, we need to pass them in cli as well.

@apanasenko-oai apanasenko-oai force-pushed the anton_panasenko_developer_instructions branch 2 times, most recently from ea25f89 to 3bab952 Compare October 29, 2025 18:44
@pakrym-oai
Copy link
Collaborator

You'll need to update parse_user_message to ignore these instructions.

@apanasenko-oai
Copy link
Collaborator Author

apanasenko-oai commented Oct 29, 2025

parse_user_message

developer instructions comes with role = developer, we don't need to filter them here, right?

        ResponseItem::Message { role, content, .. } => match role.as_str() {
            "user" => parse_user_message(content).map(TurnItem::UserMessage),
            "assistant" => Some(TurnItem::AgentMessage(parse_agent_message(content))),
            "system" => None,
            _ => None,
        },

@apanasenko-oai apanasenko-oai force-pushed the anton_panasenko_developer_instructions branch from 3bab952 to ae4d2a1 Compare October 29, 2025 22:06

/// Developer instructions that should be injected as a developer role message.
#[serde(default, skip_serializing_if = "Option::is_none")]
pub developer_instructions: Option<String>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to add this to mcp server just yet.

@apanasenko-oai apanasenko-oai force-pushed the anton_panasenko_developer_instructions branch from ae4d2a1 to d994802 Compare October 30, 2025 17:54
@apanasenko-oai apanasenko-oai merged commit 9572cfc into main Oct 30, 2025
25 checks passed
@apanasenko-oai apanasenko-oai deleted the anton_panasenko_developer_instructions branch October 30, 2025 18:18
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants