- 
                Notifications
    You must be signed in to change notification settings 
- Fork 6.1k
[TEST] File specs #5832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[TEST] File specs #5832
Conversation
| 
 I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| } | ||
|  | ||
| // esc_backtrack_hint_visible removed; hints are controlled internally. | ||
|  | ||
| pub fn set_task_running(&mut self, running: bool) { | ||
| pub fn set_task_running(&mut self, running: bool) { | ||
| self.is_task_running = running; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
  Deleting test helper breaks compilation
This change removes the ctrl_c_quit_hint_visible method from BottomPane, but the tests still invoke pane.ctrl_c_quit_hint_visible() (see the tui/src/bottom_pane/mod.rs and tui/src/chatwidget/tests.rs test modules). Because the helper no longer exists, cargo test will fail to compile with no method named ctrl_c_quit_hint_visible whenever the test suite is built. Reintroduce the helper or adjust the tests to access the state another way so that the test build succeeds.
Useful? React with 👍 / 👎.
In this PR