Skip to content

Conversation

@jumploops
Copy link

In this PR

  • Create a markdown file for every source file in the repo

@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 322 to 326
}
}

// esc_backtrack_hint_visible removed; hints are controlled internally.

pub fn set_task_running(&mut self, running: bool) {
pub fn set_task_running(&mut self, running: bool) {
self.is_task_running = running;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Deleting test helper breaks compilation

This change removes the ctrl_c_quit_hint_visible method from BottomPane, but the tests still invoke pane.ctrl_c_quit_hint_visible() (see the tui/src/bottom_pane/mod.rs and tui/src/chatwidget/tests.rs test modules). Because the helper no longer exists, cargo test will fail to compile with no method named ctrl_c_quit_hint_visible whenever the test suite is built. Reintroduce the helper or adjust the tests to access the state another way so that the test build succeeds.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant