core: render remote environment cwd natively#28152
Draft
anp-oai wants to merge 2 commits into
Draft
Conversation
167b3b9 to
5baa76a
Compare
3fc8e16 to
b91a6db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When app-server runs on Linux while the selected execution environment runs Windows, the model-visible
<environment_context>renders the selected cwd using Linux host syntax, such as/C:/windows. This gives the model a path spelling that does not match the environment where commands actually execute.Stacked on #28146.
What
PathUriwhile building environment context.TurnContextItem.cwdvalues when reconstructing and diffing context.powershellandC:\windows.TODO(anp)follow-up.Testing
just test -p codex-core context::environment_context::testsbazel test //codex-rs/core/tests/remote_env_windows:smoke-test --test_output=errors