[codex] Test process handle cleanup after spawn failure#28134
Draft
Conversation
anp-oai
force-pushed
the
codex/existing-invariant-integration-tests-05-duplicate-process-handle
branch
from
731d18e to
7a16219
Compare
anp-oai
force-pushed
the
codex/existing-invariant-integration-tests-06-spawn-handle-cleanup
branch
from
aedf5a3 to
6756a9b
Compare
anp-oai
force-pushed
the
codex/existing-invariant-integration-tests-05-duplicate-process-handle
branch
from
7a16219 to
4656232
Compare
anp-oai
force-pushed
the
codex/existing-invariant-integration-tests-06-spawn-handle-cleanup
branch
from
6756a9b to
dcee1a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protect the app-server invariant that an OS spawn failure releases its connection-scoped
processHandle.Force a missing-executable error, assert the internal-error response, then immediately reuse the same handle for a successful process and verify its exit notification.
The focused test, full
process_execintegration module, andjust fix -p codex-app-serverpass.