[codex] Refresh SSH agent for app-server proxy#28131
Draft
abhinav-oai wants to merge 1 commit into
Draft
Conversation
05f1891 to
678c078
Compare
678c078 to
2d536c6
Compare
This was referenced Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A long-running app-server can retain the
SSH_AUTH_SOCKpath from the SSH session that launched it. Once that session exits, the path points to a deleted socket even though the current proxy connection has a live forwarded agent.Add an opt-in
codex app-server proxy --forward-ssh-agentmode. The proxy validates its inherited agent socket and atomically refreshes a stableforwarded-ssh-agent.socksymlink beside the app-server control socket. If no live agent is available, it removes the stale link.A detached app-server launched with that stable path can therefore follow the current proxy connection across SSH reconnects without changing turn or command execution behavior.
Fixes #22567
Testing
cargo clippy -p codex-cli --tests -- -D warnings