Add unified exec plugin lifecycle adapter#28037
Open
kmbroai wants to merge 2 commits into
Open
Conversation
d54f4c5 to
845f73d
Compare
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 845f73d05f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responsibility
Integrate the dormant core plugin-script lifecycle tracker from #27369 into local unified-exec spawn lifecycle handling while preserving unified-exec's existing generic spawn lifecycle.
Boundary
This slice adapts
codex-rs/core/src/tools/runtimes/unified_exec.rsplus the required cross-platformSpawnLifecyclere-export incodex-rs/core/src/unified_exec/mod.rs: it resolves attribution from the originalhook_command/cwd/shell_type, composes local unified-exec lifecycle callbacks, and keeps generic lifecycle callback ordering first. Shell/zsh runtime lifecycle work remains the sibling boundary and is deliberately not included here.Dependency
Depends on #27369 (
dev/kyleb/plugin-script-lifecycle-metrics) at exact headdb17b99fbe5c1323856e9e2eebcad720cdddf4af.Deliberately deferred / excluded
Size
281 changed lines total (278 additions, 3 deletions), two intended handwritten files.
Validation
cd codex-rs && just test -p codex-core unified_exec— focused/new runtime tests passed, but required command failed locally insuite::unified_exec::unified_exec_runs_under_sandboxwith empty sandbox output; rerun required in CI.cd codex-rs && just test -p codex-core plugin_script_lifecycle— passed.cd codex-rs && just argument-comment-lint— passed.cd codex-rs && just fix -p codex-core— passed.cd codex-rs && just fmt— passed.Tracking
CLAIM_KEY=linear_issue:FOO-574,CLAIM_ID=claim-1a4aebf2007e42c1b03e896787970de3kyleb-worker-0Stack position
Slice 7/7 in FOO-574 merge order; direct dependency: #27369.