Add local credential broker#28034
Draft
winston-openai wants to merge 1 commit into
Draft
Conversation
b39d0e7 to
5446ca3
Compare
5446ca3 to
006a77a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[features.network_proxy]withcredential_broker = truerandpatch update and a narrow no-safe-upgrade exceptionbazelenvironment so this stale stack can read the current BuildBuddy secretsdksworkflow timeout after repeated Bazel/V8 compile cancellations at the previous 10-minute wallWhy
Codex child processes currently inherit injectable local credentials directly. This first slice lets the existing managed network proxy replace supported env credentials with lookalike dummy values while preserving authenticated requests through MITM.
Notes
GH_TOKEN,GITHUB_TOKEN,GH_ENTERPRISE_TOKEN,GITHUB_ENTERPRISE_TOKEN,GH_HOST, andOPENAI_API_KEYgithub.com,api.github.com, and*.ghe.comGH_HOSTbinds the destination; unbound enterprise tokens are dummied but not injectedRUSTSEC-2026-0173after the previous green main run; RustSec reports no safe upgrade forproc-macro-error2, so the exception is mirrored indeny.tomland.cargo/audit.tomlbazelGitHub Actions environment forBUILDBUDDY_API_KEY, so this carries that narrow upstream CI hunk without merging all of main through the stacksdktimed out twice while Bazel was still compiling V8, and main had a recent cancellation with the same 10-minute limit; this only widens that job to 20 minutesValidation
just write-config-schemajust test -p codex-featuresjust test -p codex-network-proxyjust test -p codex-core network_proxy_credential_broker_feature_config_requires_mitmjust fix -p codex-network-proxy -p codex-features -p codex-corejust argument-comment-lintjust fmtcargo update -p rand@0.8.5 --precise 0.8.6just bazel-lock-updatejust bazel-lock-checkenv CARGO_HOME=/tmp/cargo-home /tmp/cargo-deny/bin/cargo-deny checkruby -e 'require "yaml"; ARGV.each { |path| YAML.load_file(path) }' .github/workflows/bazel.yml .github/workflows/rust-ci.yml .github/workflows/rust-ci-full.yml .github/workflows/sdk.yml .github/workflows/rusty-v8-release.yml .github/workflows/v8-canary.ymlgit diff --checkStacked on