Rename waybar config to detect filetype #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waybar config has moved to JSONC a while ago. JSONC is a simplified JSON format which allows comments (the main useful feature missing from JSON). Renaming the config file would allow e.g. editors to detect the file type correctly.
denisok
reviewed
Mar 3, 2025
There was a problem hiding this comment.
looks like new extension is supported, so it is good to go. Yes, please update:
https://github.com/openSUSE/openSUSEway/blob/main/openSUSEway.spec#L212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waybar config has moved to JSONC a while ago. JSONC is a simplified JSON format which allows comments (the main useful feature missing from JSON). Renaming the config file would allow e.g. editors to detect the file type correctly.
This will need a corresponding packaging adjustment to match and preserve the new filename.