Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some applications to default floating #132

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Add some applications to default floating #132

merged 3 commits into from
Jan 23, 2024

Conversation

krishjainx
Copy link
Contributor

Let us close #38

@krishjainx
Copy link
Contributor Author

@FilippoBonazziSUSE @denisok

@FilippoBonazziSUSE
Copy link
Collaborator

Ok for me, except adding a 30-windows.conf file side by side with 50-openSUSE.conf makes it look like it has to do with MS Windows. This could be the opportunity to rename the main openSUSEway Sway config file and possibly also split it up (I've been kicking that can down the road for a while)

@krishjainx
Copy link
Contributor Author

How about we merge this and then address that task in a separate PR? @FilippoBonazziSUSE

@FilippoBonazziSUSE
Copy link
Collaborator

Sure, that's fine for me. We already have #49 open to track the config file modularization topic.

I am leaving this open for @denisok to review as well. Specifically if he is ok with adding the separate 30-windows.conf file right now or he'd rather keep everything in 50-openSUSE.conf for now.

@krishjainx krishjainx mentioned this pull request Jan 18, 2024
Open
denisok
denisok reviewed Jan 18, 2024
View reviewed changes
@denisok denisok added this to the 0.16.0 milestone Jan 18, 2024
@krishjainx
Copy link
Contributor Author

Done @denisok

@denisok denisok merged commit bfc6ec6 into openSUSE:main Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denisok denisok denisok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.

add some applications to default floating
3 participants
@krishjainx @FilippoBonazziSUSE @denisok