make brightness control via hotkeys exponential #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As brightness is perceived exponentially, it is more intuitive to make the brightness change exponentially as well.
the previous brightness calculation did not round to the nearest integer, this perl script does now do that
denisok
requested changes
May 22, 2023
There was a problem hiding this comment.
Otherwise doesn't work for me:
May 22 11:52:37 stdlen sway[4702]: Execution of -e aborted due to compilation errors.
May 22 11:52:37 stdlen sway[4702]: syntax error at -e line 1, near "%.0"
May 22 11:52:37 stdlen sway[4702]: (Missing operator before f?)
May 22 11:52:37 stdlen sway[4702]: Bareword found where operator expected at -e line 1, near "0f"
May 22 11:52:37 stdlen sway[4702]: (Missing operator before 0?)
May 22 11:52:37 stdlen sway[4702]: Number found where operator expected at -e line 1, near "%.0"
|
@nova-r could you please check suggestions? |
Co-authored-by: Denys Kondratenko <[email protected]>
|
@FilippoBonazziSUSE could you please check this one. When I checked it last time, it didn't work for me. |
FilippoBonazziSUSE
requested changes
Jan 25, 2024
There was a problem hiding this comment.
The commands work for me (with the necessary ' to " fix) in the sense that they succeed in changing brightness.
However, there are 3 things that I would like to see changed:
- The use of the Perl interpreter is not ideal, and I'd like to avoid it if at all possible. Any extra dependency must be carefully considered
- The brightness up and down commands are not symmetrical, i.e. increments on the way up are different from decrements on the way down. This makes brightness values not reproducible and arbitrary looking. For example, starting from 20%, going up to 100% takes N increments, but going back down N decrements arrives at 19%. This needs to be fixed before this can be merged.
- There is no progress on the discussion we had in make brightness control exponential #112 , and I'd like to see those points addressed too
| bindsym XF86MonBrightnessDown exec brightnessctl -q set 5%- && ( echo $((`brightnessctl get` * 100 / `brightnessctl m`)) > $SWAYSOCK.wob ) | ||
| bindsym XF86MonBrightnessUp exec brightnessctl -q set +5% && ( echo $((`brightnessctl get` * 100 / `brightnessctl m`)) > $SWAYSOCK.wob ) | ||
| bindsym XF86MonBrightnessDown exec brightnessctl -q -e set 5%- && ( perl -e "use Math::Complex; printf \"%.0f\n\", 100 * ((`brightnessctl get` / `brightnessctl m`)**0.25)" > $SWAYSOCK.wob ) | ||
| bindsym XF86MonBrightnessUp exec brightnessctl -q -e set +5% && ( perl -e 'use Math::Complex; printf \"%.0f\n\", 100 * ((`brightnessctl get` / `brightnessctl m`)**0.25)' > $SWAYSOCK.wob ) |
There was a problem hiding this comment.
Also here the ' string delimiter needs to be changed to "
|
@denisok This feature will take a bit more time, let's not wait for this for 0.16.0 |
mcepl
suggested changes
Jan 30, 2024
| @@ -37,8 +37,8 @@ bindsym --to-code { | |||
| # Media keys | |||
| bindsym XF86AudioMicMute exec pactl set-source-mute @DEFAULT_SOURCE@ toggle | |||
|
|
|||
| bindsym XF86MonBrightnessDown exec brightnessctl -q set 5%- && ( echo $((`brightnessctl get` * 100 / `brightnessctl m`)) > $SWAYSOCK.wob ) | |||
| bindsym XF86MonBrightnessUp exec brightnessctl -q set +5% && ( echo $((`brightnessctl get` * 100 / `brightnessctl m`)) > $SWAYSOCK.wob ) | |||
| bindsym XF86MonBrightnessDown exec brightnessctl -q -e set 5%- && ( perl -e "use Math::Complex; printf \"%.0f\n\", 100 * ((`brightnessctl get` / `brightnessctl m`)**0.25)" > $SWAYSOCK.wob ) | |||
There was a problem hiding this comment.
Pulling in yet another programming language (Perl) is not a good idea. Look at #126 as well.
There was a problem hiding this comment.
Can we simply use awk for this task?
Consider the following, formatted across multiple lines for clarity:
brightness=$(brightnessctl get)
max_brightness=$(brightnessctl m)
percentage=$(awk -v br="$brightness" -v max="$max_brightness" 'BEGIN {printf "%.0f\n", 100 * ((br / max) ^ 0.25)}')
echo $percentage > $SWAYSOCK.wob
There was a problem hiding this comment.
We could use just bc:
mitmanek~$ echo "scale=2 ; 100 * e(l("$(brightnessctl get)" / "$(brightnessctl m)") * 0.25)"|bc -l
78.00There was a problem hiding this comment.
That's an additional dependency though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #112
As brightness is perceived exponentially, it is more intuitive to make the brightness change exponentially as well.