Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for Leap Micro #76

Merged
merged 32 commits into from
Mar 31, 2022
Merged

Initial commit for Leap Micro #76

merged 32 commits into from
Mar 31, 2022

Conversation

lkocman
Copy link
Contributor

@lkocman lkocman commented Mar 30, 2022

  • Issue with includes in distribution_leapmicro.html SOLUTION: page removed All the links issues went away/

    I'm getting Invalid Syntax for whatever reason. I reduced the page to the point where it builds, but page needs to be extended.

  • Other pages seem to be broken by my change

  • Why are logos seen as black in inkscape but rendered as white on
    get-o-o? And why it doesn't work for Leap Micro ? :)

  • I used Dark Blue 25% color from official https://en.opensuse.org/Help:Colors as it looked nice with the original orange logo. I hope that's okay. Resolution: Changed to light brown.

  • The testing version for leap is somehow seen as 5.1 on the main page, but the leapmicro_testing gets it correctly (5.2)

  • Remove 5.1 as that one was for debug purpose only. As of now there should be only a testing version

  • Use correct paths for images (current ones are taken from MicroOS)

main_page
leapmicro_testing

* Issue with includes in distribution_leapmicro.html
  I'm getting Invalid Syntax for whatever reason

* Other pages seem to be broken

* Perhaps we don't have to duplicate code in labeltorelease.rb

* Why are logos seen as black in inkscape but rendered as white on
  get-o-o? And why it doesn't work for Leap Micro ? :)
@lkocman lkocman requested a review from hellcp March 30, 2022 15:46
@lkocman
Copy link
Contributor Author

lkocman commented Mar 30, 2022

Hello @hellcp I'm no Ruby devel, and the issue includes throwing an Invalid syntax exception with are killing my progress

{% include {{ distro.logo }} %}

While following returns "logos/leapmicro.svg" (so I suppose data is loaded correctly).
{{ distro.logo | jsonify }}

Not sure what's fundamentally wrong. Any sort of help is highly welcome

@lkocman
Copy link
Contributor Author

lkocman commented Mar 30, 2022

The color is now fixed. Thanks for the hint @hellcp
fixed_color

@lkocman
Copy link
Contributor Author

lkocman commented Mar 30, 2022

current_state_downloads
current_state
current_state_main

@lkocman
Copy link
Contributor Author

lkocman commented Mar 30, 2022

The 5.1 is still a bummer

@lkocman
Copy link
Contributor Author

lkocman commented Mar 31, 2022

This looks decent, now I'll process translations of used strings and it's almost done.
downloads

lkocman added 2 commits March 31, 2022 11:16
* strings copied from google translate typed in with vim
  settings :set keymap=arabic
@hellcp
Copy link
Member

hellcp commented Mar 31, 2022

You don't have to fill out the languages yourself, they will be updated from weblate if there is an entry in en.yml

@lkocman lkocman changed the title DO NOT MERGE: Initial commit for Leap Micro Initial commit for Leap Micro Mar 31, 2022
@lkocman lkocman requested a review from hellcp March 31, 2022 13:28
@lkocman
Copy link
Contributor Author

lkocman commented Mar 31, 2022

You don't have to fill out the languages yourself, they will be updated from weblate if there is an entry in en.yml

:-) well I've asked if it's manual or not ... on irc :-)

@lkocman
Copy link
Contributor Author

lkocman commented Mar 31, 2022

I'm quite happy with what I see rendered. In next iterations I thinik the preconfigured images should be the most downloaded item, therefore we should merge them to the main download site.

main
dvd
testing

images

@lkocman lkocman requested a review from hellcp March 31, 2022 17:06
@hellcp
Copy link
Member

hellcp commented Mar 31, 2022

I would remove the translation changes, so the translators can do it properly, but it's not a requirement. Feel free to merge

@lkocman
Copy link
Contributor Author

lkocman commented Mar 31, 2022

@hellcp I'll keep, Czech, German and Slovak as for these I did get an actual review :-) Rest can be dropped

lkocman added 3 commits March 31, 2022 20:14
* leave it on weblate, gtranslate probably didn't do great job here

This reverts commit 385a55f.
@lkocman lkocman merged commit 5c69ba1 into openSUSE:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants