Adding eq method to collection #41
Conversation
I was trying to add a test too but it seems there was a problem with the test. It should have been correct if the code for the test was running the new version, but that was not the case. |
|
|
||
| def __eq__(self, other: Node) -> bool: | ||
|
|
||
| for property in self.properties: |
There was a problem hiding this comment.
also need to check equality self._type_ and self.id (if it is defined, i.e., for LinkedMetadata, but not for EmbeddedMetadata, and if it is not None)
| def __eq__(self, other): | ||
|
|
||
| # The current implementation assumes that nodes in both graphs are connected with the same link number. | ||
| for node_id in self.nodes: |
There was a problem hiding this comment.
also need to check that there are no extra nodes in other that are not present in self.
| @@ -34,6 +34,18 @@ def __len__(self): | |||
|
|
|||
| def __iter__(self): | |||
| return iter(self.nodes.values()) | |||
|
|
|||
| def __eq__(self, other): | |||
There was a problem hiding this comment.
Maybe add a preliminary check that the len() of both collections are the same? If they're different, we can return False quickly without needing to check all the nodes.
No description provided.