Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

studied state was not connected #60

Merged
merged 3 commits into from
Jun 19, 2024
Merged

studied state was not connected #60

merged 3 commits into from
Jun 19, 2024

Conversation

Peyman-N
Copy link
Member

When creating the state just from file structure, the resulted subject state is not connected to subject.

@Peyman-N Peyman-N requested review from lzehl and apdavison June 18, 2024 16:12
apdavison
apdavison requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@apdavison apdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a test, which should fail with the current main branch but pass with this PR.

@Peyman-N Peyman-N requested a review from apdavison June 19, 2024 12:57
@apdavison apdavison merged commit 465880b into openMetadataInitiative:main Jun 19, 2024
4 checks passed
@Peyman-N Peyman-N deleted the studied_states_error branch October 17, 2024 14:54
@Peyman-N Peyman-N restored the studied_states_error branch October 17, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apdavison apdavison apdavison approved these changes

@lzehl lzehl Awaiting requested review from lzehl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Peyman-N @apdavison