-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHEE-684] Reporting CRUD APIs Integration Test #296
Open
atul18102003
wants to merge
17
commits into
openMF:master
Choose a base branch
from
atul18102003:ReportTest
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+419
−4
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e9fe64b
Integration testing for CRUD APIs.
atul18102003 42ce7ea
Integration testing for CRUD APIs.
atul18102003 29194c5
fix checkstyle issues
atul18102003 c91df58
fix checkstyle issues
atul18102003 c049613
fix checkstyle issues
atul18102003 bf229a1
fix checkstyle issues
atul18102003 eef5d6e
fix checkstyle issues
atul18102003 ae4083a
fix checkstyle issues
atul18102003 166cc12
fix checkstyle issues
atul18102003 76a2607
fix checkstyle issues
atul18102003 b01b762
fix checkstyle issues
atul18102003 3240618
testing issue resolve
atul18102003 ea21ea8
testing issue resolve
atul18102003 f1eb359
testing issue resolve
atul18102003 f1ba029
testing issue resolve
atul18102003 0884969
change file dir
atul18102003 e730943
change file dir
atul18102003 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,10 +4,12 @@ | |
import org.springframework.boot.context.properties.ConfigurationProperties; | ||
import org.springframework.boot.context.properties.EnableConfigurationProperties; | ||
import org.springframework.context.annotation.Configuration; | ||
import org.springframework.stereotype.Component; | ||
|
||
@Configuration | ||
@EnableConfigurationProperties | ||
@ConfigurationProperties(prefix = "tenantconfig") | ||
@Component | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't need Component annotation here. |
||
public class TenantConfig { | ||
|
||
public void setTenants(HashMap<String, String> tenants) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,10 @@ operations-app: | |
variables: "/api/v1/variables" | ||
transactionRequests: "/api/v1/transactionRequests" | ||
actuator: "/actuator/health" | ||
reportEndpoint: "/reports" | ||
reportCreate : "/reports" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why multiple configurations for the same values? 1 or 2 configurations would have sufficed here instead of 4. |
||
reportUpdate : "/reports/{id}" | ||
reportSingleReport: "/reports/{id}" | ||
|
||
paybill: | ||
mpesa-connector: | ||
|
20 changes: 20 additions & 0 deletions
20
src/test/java/org/mifos/integrationtest/common/dto/operationsapp/ReportParameter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package org.mifos.integrationtest.common.dto.operationsapp; | ||
|
||
import lombok.AllArgsConstructor; | ||
import lombok.Data; | ||
import lombok.NoArgsConstructor; | ||
|
||
@Data | ||
@AllArgsConstructor | ||
@NoArgsConstructor | ||
|
||
public class ReportParameter { | ||
|
||
private Long id; | ||
|
||
private ReportRequestDTO reportRequest; | ||
|
||
private String parameterKey; | ||
|
||
private String parameterValue; | ||
} |
26 changes: 26 additions & 0 deletions
26
src/test/java/org/mifos/integrationtest/common/dto/operationsapp/ReportRequestDTO.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package org.mifos.integrationtest.common.dto.operationsapp; | ||
|
||
import java.util.List; | ||
import lombok.Getter; | ||
import lombok.Setter; | ||
|
||
@Getter | ||
@Setter | ||
public class ReportRequestDTO { | ||
|
||
private Long id; | ||
|
||
private String reportName; | ||
|
||
private String reportType; | ||
|
||
private String reportSubType; | ||
|
||
private String reportCategory; | ||
|
||
private String description; | ||
|
||
private String reportSql; | ||
|
||
private List<ReportParameter> reportParameters; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to be careful while raising PRs to not push changes done for local testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually there is only one ngnox in openci so if someone else run there pipeline mine will not work that's why used this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are ngnox and openci, never heard of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be merged? If not, and you made the change for testing purposes, then the PR is not in the ready for review (RPR) state. It should have been a draft PR and moved to ready for review only after reversing this change.