Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed Desktop Build & Added Firebase App Distribution #1816

Merged
merged 49 commits into from
Nov 19, 2024
Merged
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
348ec06
Feat: KMP Library Setup (#1766)
niyajali Sep 24, 2024
a3b4fd3
Feat: [:core:model] - Migrated to KMM (#1770)
niyajali Sep 26, 2024
d6623f8
Feat: [:core:common] KMP Migration (#1768)
niyajali Sep 26, 2024
f03a2a0
Feat: [:core:datastore] - Migrated to KMP (#1769)
niyajali Sep 26, 2024
278da28
Feat: [:core:network] - Migrated to KMP (#1772)
niyajali Sep 30, 2024
d5b7c52
Feat: [:core:designsystem] - Migrated to KMP with CMP Library (#1774)
niyajali Sep 30, 2024
69a04d8
Feat: [:core:ui] - Migrated to KMP with CMP Library (#1775)
niyajali Sep 30, 2024
ae2b15b
Feat: [:feature:auth] - Migrated to Kotlin Multiplatform (#1782)
niyajali Oct 7, 2024
a1ca686
Feat: Migrated Passcode Module to KMP (#1783)
niyajali Oct 8, 2024
d295cab
Feat: Migrated Home Module to KMP (#1784)
niyajali Oct 10, 2024
a4360f2
Feat: Migrated Edit Password Module to KMP (#1787)
niyajali Oct 12, 2024
384af4f
Feat: Migrated FAQ module to kmp (#1786)
niyajali Oct 12, 2024
d78a798
Feat: Migrated Settings Module to KMP (#1785)
niyajali Oct 12, 2024
5d84fb5
Feat: Migrated Profile Module to KMP (#1788)
niyajali Oct 14, 2024
32498f6
Feat: Migrated History Module to KMP (#1790)
niyajali Oct 14, 2024
0121c2a
Feat: Migrated Payments Module to KMP (#1791)
niyajali Oct 15, 2024
723b13b
Feat: Migrated Finance Module to KMP (#1792)
niyajali Oct 15, 2024
20ba4ee
Feat: Migrated Accounts Module to KMP (#1793)
niyajali Oct 19, 2024
de590f8
Feat: Migrated Invoices Module to KMP (#1794)
niyajali Oct 21, 2024
7a4c54e
Feat: Migrated KYC Module to KMP (#1798)
niyajali Oct 25, 2024
3135f66
Migrated Notification Module to KMP (#1799)
niyajali Oct 25, 2024
ff171dd
Feat: Migrated Saved Card Module to KMP (#1800)
niyajali Oct 27, 2024
311d0b5
Feat: Migrated Receipt Module to KMP (#1801)
niyajali Oct 27, 2024
67661de
fix: Ios Build (#1802)
therajanmaurya Oct 28, 2024
c553d95
Feat: Migrated SI Module to KMP (#1803)
niyajali Oct 29, 2024
2a5f1bf
Feat: Migrated Request Money Module to KMP (#1807)
niyajali Oct 31, 2024
8a27c14
Feat: Migrated Send Money Module to KMP (#1808)
niyajali Nov 1, 2024
809e0a3
Feat: Migrated Make Transfer Module to KMP (#1809)
niyajali Nov 2, 2024
f0ff23b
Feat: Migrated QR Module to KMP (#1810)
niyajali Nov 4, 2024
a246b70
Feat: Migrated UPI Setup Module to KMP (#1811)
niyajali Nov 4, 2024
55ba062
Feat: Final Clean-up For KMP (#1812)
niyajali Nov 5, 2024
6343e7d
Merge remote-tracking branch 'origin/kmm-impl' into dev
niyajali Nov 6, 2024
2d2b55a
Migrating from hilt to koin (This) (#1764)
Nagarjuna0033 Sep 23, 2024
c0845b7
Profile UI redesign (#1767)
itsPronay Sep 25, 2024
150698f
refactor: Redesign payment screen (#1773)
Nagarjuna0033 Oct 1, 2024
2974820
refactor: Redesign finance screen (#1777)
Nagarjuna0033 Oct 3, 2024
3d32980
fix: dark theme colors (#1789)
Nagarjuna0033 Oct 18, 2024
d582fa2
Fix invoice api (#1797)
Nagarjuna0033 Oct 25, 2024
89d919a
update readme file (#1804)
kapmaurya Oct 30, 2024
c3e8b07
Add branch policy (#1805)
kapmaurya Oct 30, 2024
09abe15
Merge remote-tracking branch 'origin/dev' into dev
niyajali Nov 6, 2024
f260d8d
Migrating from hilt to koin (This) (#1764)
Nagarjuna0033 Sep 23, 2024
7e0b164
Merge kmm-impl to dev
niyajali Nov 6, 2024
5a5966b
Merge branch 'openMF:dev' into dev
niyajali Nov 6, 2024
7e60a03
Merge branch 'openMF:dev' into dev
niyajali Nov 19, 2024
ca44781
Update make_site.yaml
niyajali Nov 19, 2024
b5208bb
fix: Fixed Desktop Versioning
niyajali Nov 19, 2024
8c2736e
Merge remote-tracking branch 'origin/dev' into dev
niyajali Nov 19, 2024
84fd7a0
- Added Firebase App Distribution
niyajali Nov 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/actions/inflate-secrets/action.yml
Original file line number Diff line number Diff line change
@@ -10,6 +10,9 @@ inputs:
playstore-creds:
description: 'The playstore credentials to inflate'
required: true
firebase-creds:
description: 'The firebase credentials to inflate'
required: true
runs:
using: 'composite'
steps:
@@ -38,3 +41,10 @@ runs:
CREDS: ${{ inputs.playstore-creds }}
run: |
echo $CREDS > mifospay-android/playStorePublishServiceCredentialsFile.json

- name: Inflate firebaseAppDistributionServiceCredentialsFile.json
shell: bash
env:
CREDS: ${{ inputs.firebase-creds }}
run: |
echo $CREDS > mifospay-android/firebaseAppDistributionServiceCredentialsFile.json
13 changes: 13 additions & 0 deletions .github/mockFirebaseAppDistributionServiceCredentialsFile.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"type": "service_account",
"project_id": "mifoswallet-baa0c",
"private_key_id": "private_key_id",
"private_key": "private_key",
"client_email": "client_email",
"client_id": "111380693391682832489",
"auth_uri": "https://accounts.google.com/o/oauth2/auth",
"token_uri": "https://oauth2.googleapis.com/token",
"auth_provider_x509_cert_url": "https://www.googleapis.com/oauth2/v1/certs",
"client_x509_cert_url": "https://www.googleapis.com/robot/v1/metadata/x509/firebase-adminsdk-w3hi9%40mifoswallet-baa0c.iam.gserviceaccount.com",
"universe_domain": "googleapis.com"
}
19 changes: 18 additions & 1 deletion .github/workflows/internal_or_beta_release.yml
Original file line number Diff line number Diff line change
@@ -42,7 +42,7 @@ jobs:
run: ./gradlew packageReleaseDistributionForCurrentOS

app_build:
name: Github, Firebase, and Sentry Release
name: Github, Firebase Release
needs: [ build_desktop_app ]
runs-on: ubuntu-latest
permissions:
@@ -76,6 +76,7 @@ jobs:
keystore: ${{ secrets.ORIGINAL_KEYSTORE_FILE }}
google-services: ${{ secrets.GOOGLESERVICES }}
playstore-creds: ${{ secrets.PLAYSTORECREDS }}
firebase-creds: ${{ secrets.FIREBASECREDS }}

- uses: ./.github/actions/create-release-notes
name: Create Release Notes
@@ -121,6 +122,15 @@ jobs:
./mifospay-desktop/build/compose/binaries/main-release/msi/*.msi
./mifospay-desktop/build/compose/binaries/main-release/deb/*.deb
./mifospay-desktop/build/compose/binaries/main-release/dmg/*.dmg


- name: ☁️ Deploy to Firebase
env:
KEYSTORE_PASSWORD: ${{ secrets.ORIGINAL_KEYSTORE_FILE_PASSWORD }}
KEYSTORE_ALIAS: ${{ secrets.ORIGINAL_KEYSTORE_ALIAS }}
KEYSTORE_ALIAS_PASSWORD: ${{ secrets.ORIGINAL_KEYSTORE_ALIAS_PASSWORD }}
VERSION_CODE: ${{ steps.rel_number.outputs.version-code }}
run: ./gradlew appDistributionUploadProdRelease --no-configuration-cache

- name: Print `git status`
run: git status
@@ -161,6 +171,7 @@ jobs:
keystore: ${{ secrets.UPLOAD_KEYSTORE_FILE }}
google-services: ${{ secrets.GOOGLESERVICES }}
playstore-creds: ${{ secrets.PLAYSTORECREDS }}
firebase-creds: ${{ secrets.FIREBASECREDS }}

- uses: ./.github/actions/create-release-notes
name: Create Release Notes
@@ -177,6 +188,12 @@ jobs:
run: |
./gradlew :mifospay-android:bundleRelease

- name: Archive Build
uses: actions/upload-artifact@v4
with:
name: release-aabs
path: ./**/*.aab

- name: Deploy to Playstore Internal
run: bundle exec fastlane deploy_internal

4 changes: 2 additions & 2 deletions .github/workflows/make_site.yaml
Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@ jobs:
environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
runs-on: ubuntu-latest
runs-on: windows-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
@@ -46,4 +46,4 @@ jobs:

- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v4
uses: actions/deploy-pages@v4
37 changes: 7 additions & 30 deletions .github/workflows/master_dev_ci.yml
Original file line number Diff line number Diff line change
@@ -64,6 +64,7 @@ jobs:




dependency_guard:
needs: setup
runs-on: ubuntu-latest
@@ -100,32 +101,8 @@ jobs:
disable_globbing: true
commit_message: "🤖 Updates baselines for Dependency Guard"

tests_and_lint:
needs: setup
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: 17
- name: Run tests
run: |
./gradlew :mifospay-android:testDemoDebug
# ./gradlew testDemoDebug :lint:test :mifospay-android:lintProdRelease :lint:lint
- name: Upload reports
if: always()
uses: actions/upload-artifact@v4
with:
name: test-and-lint-reports
path: |
**/build/reports/lint-results-*.html
**/build/test-results/test*UnitTest/**.xml



build:
needs: [ checks, dependency_guard, tests_and_lint ]
needs: [ checks, dependency_guard ]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
@@ -145,11 +122,11 @@ jobs:
- name: Upload APKs
uses: actions/upload-artifact@v4
with:
name: APKs
name: Android APKs
path: '**/build/outputs/apk/**/*.apk'

build_desktop_app:
needs: [ checks, dependency_guard, tests_and_lint ]
needs: [ checks, dependency_guard ]
strategy:
matrix:
os:
@@ -174,7 +151,7 @@ jobs:
if: matrix.os == 'windows-latest'
uses: actions/upload-artifact@v4
with:
name: Windows-App
name: Windows-Apps
path: |
./mifospay-desktop/build/compose/binaries/main/exe/*.exe
./mifospay-desktop/build/compose/binaries/main/msi/*.msi
@@ -183,12 +160,12 @@ jobs:
if: matrix.os == 'ubuntu-latest'
uses: actions/upload-artifact@v4
with:
name: Windows-App
name: Linux-App
path: './mifospay-desktop/build/compose/binaries/main/deb/*.deb'

- name: Upload MacOS App
if: matrix.os == 'macos-latest'
uses: actions/upload-artifact@v4
with:
name: Windows-App
name: MacOS-App
path: './mifospay-desktop/build/compose/binaries/main/dmg/*.dmg'
1 change: 1 addition & 0 deletions .github/workflows/release_to_production.yml
Original file line number Diff line number Diff line change
@@ -26,6 +26,7 @@ jobs:
keystore: ${{ secrets.ORIGINAL_KEYSTORE_FILE }}
google-services: ${{ secrets.GOOGLESERVICES }}
playstore-creds: ${{ secrets.PLAYSTORECREDS }}
firebase-creds: ${{ secrets.FIREBASECREDS }}

- name: Promote Beta to Production Play Store
run: bundle exec fastlane promote_to_production
2 changes: 1 addition & 1 deletion .github/workflows/weekly.yaml
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ jobs:

- name: Tag Weekly Release
env:
GITHUB_TOKEN: ${{ secrets.TAG_PUSH_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: ./gradlew :reckonTagPush -Preckon.stage=final

- name: Trigger Workflow
1 change: 1 addition & 0 deletions build.gradle.kts
Original file line number Diff line number Diff line change
@@ -16,6 +16,7 @@ plugins {
alias(libs.plugins.kotlin.parcelize) apply false
alias(libs.plugins.dependencyGuard) apply false
alias(libs.plugins.firebase.crashlytics) apply false
alias(libs.plugins.firebase.appdistribution) apply false
alias(libs.plugins.firebase.perf) apply false
alias(libs.plugins.gms) apply false
alias(libs.plugins.ksp) apply false
5 changes: 0 additions & 5 deletions core/data/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -34,11 +34,6 @@ kotlin {
implementation(libs.kotlinx.serialization.json)
}

commonTest.dependencies {
implementation(libs.multiplatform.settings)
implementation(libs.multiplatform.settings.test)
}

androidMain.dependencies {
implementation(libs.androidx.core.ktx)
implementation(libs.androidx.tracing.ktx)
1 change: 0 additions & 1 deletion core/datastore-proto/.gitignore

This file was deleted.

3 changes: 0 additions & 3 deletions core/datastore-proto/README.md

This file was deleted.

43 changes: 0 additions & 43 deletions core/datastore-proto/build.gradle.kts

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

2 changes: 1 addition & 1 deletion core/datastore/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -9,6 +9,7 @@
*/
plugins {
alias(libs.plugins.mifospay.kmp.library)
id("kotlinx-serialization")
}

android {
@@ -33,7 +34,6 @@ kotlin {
implementation(libs.kotlinx.serialization.core)
implementation(projects.core.model)
implementation(projects.core.common)
implementation(projects.core.datastoreProto)
}

commonTest.dependencies {
Original file line number Diff line number Diff line change
@@ -9,9 +9,9 @@
*/
package org.mifospay.core.datastore

import org.mifospay.core.datastore.proto.ClientPreferences
import org.mifospay.core.datastore.proto.RolePreferences
import org.mifospay.core.datastore.proto.UserInfoPreferences
import org.mifospay.core.datastore.model.ClientPreferences
import org.mifospay.core.datastore.model.RolePreferences
import org.mifospay.core.datastore.model.UserInfoPreferences
import org.mifospay.core.model.client.Client
import org.mifospay.core.model.user.RoleInfo
import org.mifospay.core.model.user.UserInfo
Original file line number Diff line number Diff line change
@@ -22,8 +22,8 @@ import kotlinx.coroutines.flow.map
import kotlinx.coroutines.withContext
import kotlinx.serialization.ExperimentalSerializationApi
import org.mifospay.core.datastore.UserPreferencesDataSource.Companion.DEFAULT_ACCOUNT
import org.mifospay.core.datastore.proto.ClientPreferences
import org.mifospay.core.datastore.proto.UserInfoPreferences
import org.mifospay.core.datastore.model.ClientPreferences
import org.mifospay.core.datastore.model.UserInfoPreferences
import org.mifospay.core.model.account.DefaultAccount
import org.mifospay.core.model.client.Client
import org.mifospay.core.model.client.UpdatedClient
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
*
* See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
*/
package org.mifospay.core.datastore.proto
package org.mifospay.core.datastore.model

import kotlinx.serialization.Serializable

Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
*
* See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
*/
package org.mifospay.core.datastore.proto
package org.mifospay.core.datastore.model

import kotlinx.serialization.Serializable

Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
*
* See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
*/
package org.mifospay.core.datastore.proto
package org.mifospay.core.datastore.model

import kotlinx.serialization.Serializable

Loading