refactor #1531: migrated payments screen to compose #1548
Merged
+1,449
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PratyushSingh07
force-pushed
the
payments-compose
branch
from
41d1a7e to
99f2485
Compare
3 tasks
|
Please review this @therajanmaurya . I have migrated the payments screen to compose. Please review and merge this . Once merged I will look for any other bugs and edge cases that I might have missed |
therajanmaurya
requested changes
Mar 22, 2024
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/history/presenter/HistoryViewModel.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/history/presenter/HistoryViewModel.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/history/ui/HistoryItem.kt
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/history/ui/HistoryItem.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/history/ui/HistoryScreen.kt
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/home/ui/PaymentsFragment.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/home/ui/PaymentsFragment.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/home/ui/PaymentsScreen.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/home/ui/PaymentsScreen.kt
Outdated
Show resolved
Hide resolved
PratyushSingh07
force-pushed
the
payments-compose
branch
from
f331111 to
61479ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Fix
Fixes #1531
payments.screen.mp4
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.