refactor : converted core model java class to kotilin data class #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiranjanNlc
force-pushed
the
domainClients
branch
from
c43a414 to
9f03e29
Compare
NiranjanNlc
force-pushed
the
domainClients
branch
from
d00bee6 to
3177b8a
Compare
NiranjanNlc
changed the title
therajanmaurya
requested changes
Feb 26, 2024
.../data/src/main/java/org/mifos/mobilewallet/core/data/fineract/entity/mapper/AccountMapper.kt
Outdated
Show resolved
Hide resolved
.../data/src/main/java/org/mifos/mobilewallet/core/data/fineract/entity/mapper/AccountMapper.kt
Outdated
Show resolved
Hide resolved
...src/main/java/org/mifos/mobilewallet/core/data/fineract/entity/mapper/ClientDetailsMapper.kt
Outdated
Show resolved
Hide resolved
core/data/src/main/java/org/mifos/mobilewallet/core/data/fineract/entity/mapper/FetchAccount.kt
Outdated
Show resolved
Hide resolved
core/data/src/main/java/org/mifos/mobilewallet/core/data/fineract/entity/mapper/FetchAccount.kt
Outdated
Show resolved
Hide resolved
.../main/java/org/mifos/mobilewallet/core/data/fineract/entity/mapper/SearchedEntitiesMapper.kt
Outdated
Show resolved
Hide resolved
core/data/src/main/java/org/mifos/mobilewallet/core/domain/usecase/account/FetchAccount.kt
Outdated
Show resolved
Hide resolved
core/data/src/main/java/org/mifos/mobilewallet/core/domain/usecase/account/FetchAccount.kt
Outdated
Show resolved
Hide resolved
core/model/src/main/java/com/mifos/mobilewallet/model/domain/Account.kt
Outdated
Show resolved
Hide resolved
core/model/src/main/java/com/mifos/mobilewallet/model/domain/Transaction.kt
Outdated
Show resolved
Hide resolved
therajanmaurya
requested changes
Feb 26, 2024
...a/src/main/java/org/mifos/mobilewallet/core/data/fineract/entity/mapper/TransactionMapper.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Fix
Fixes #1529
Screenshots
No change in UI
Description
converted the java classes of the domain client package and clientmapper.java classes to kotilin
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.