refactor #1537: migrated faq screen to compose #1538
Merged
+189
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PratyushSingh07
force-pushed
the
faq-compose
branch
from
7a2450b to
c0d6db4
Compare
therajanmaurya
requested changes
Feb 18, 2024
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/faq/ui/FAQActivity.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/faq/ui/FAQActivity.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/faq/ui/FAQ.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/faq/ui/FAQActivity.kt
Show resolved
Hide resolved
...m/src/main/java/org/mifos/mobilewallet/mifospay/designsystem/component/MifosFaqItemHolder.kt
Outdated
Show resolved
Hide resolved
...m/src/main/java/org/mifos/mobilewallet/mifospay/designsystem/component/MifosFaqItemHolder.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/faq/ui/FAQActivity.kt
Outdated
Show resolved
Hide resolved
PratyushSingh07
force-pushed
the
faq-compose
branch
from
f5f6349 to
aec8790
Compare
|
done the changes @therajanmaurya |
therajanmaurya
requested changes
Feb 20, 2024
...system/src/main/java/org/mifos/mobilewallet/mifospay/designsystem/component/FaqItemScreen.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/faq/ui/FAQ.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/faq/ui/FaqScreen.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/faq/ui/FAQActivity.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/faq/ui/FAQActivity.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/faq/ui/FAQActivity.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/faq/ui/FAQActivity.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/faq/ui/FaqScreen.kt
Show resolved
Hide resolved
| faqViewModel: FAQViewModel = hiltViewModel(), | ||
| updateFaqPosition: (Int) -> Unit, | ||
| ) { | ||
| Column(modifier = Modifier.fillMaxSize()) { |
There was a problem hiding this comment.
Call below-suggested function and move this content in it.
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/faq/ui/FaqScreen.kt
Outdated
Show resolved
Hide resolved
therajanmaurya
requested changes
Feb 20, 2024
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/faq/ui/FaqScreen.kt
Show resolved
Hide resolved
PratyushSingh07
force-pushed
the
faq-compose
branch
from
e38f2cb to
fa8461a
Compare
therajanmaurya
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Fix
Fixes #1537
Earlier Design:
Faq.modified.mp4
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.